Module: Mesa Branch: master Commit: c40ea24ee009d8c9816ff6327f65be3fbd45deb7 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c40ea24ee009d8c9816ff6327f65be3fbd45deb7
Author: Samuel Pitoiset <samuel.pitoi...@gmail.com> Date: Thu Jan 21 13:39:27 2021 +0100 radv: fix overflow when computing the SQTT buffer size With RADV_THREAD_TRACE_BUFFER_SIZE=1073741824, the computed size will overflow and be 4096 instead of 4294967296. Cc: <mesa-sta...@lists.freedesktop.org> Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> Reviewed-by: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8616> --- src/amd/vulkan/radv_sqtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_sqtt.c b/src/amd/vulkan/radv_sqtt.c index 263a963256f..ecd83fed728 100644 --- a/src/amd/vulkan/radv_sqtt.c +++ b/src/amd/vulkan/radv_sqtt.c @@ -477,7 +477,7 @@ radv_thread_trace_init_bo(struct radv_device *device) /* Compute total size of the thread trace BO for 4 SEs. */ size = align64(sizeof(struct ac_thread_trace_info) * 4, 1 << SQTT_BUFFER_ALIGN_SHIFT); - size += device->thread_trace.buffer_size * 4; + size += device->thread_trace.buffer_size * 4ll; device->thread_trace.bo = ws->buffer_create(ws, size, 4096, RADEON_DOMAIN_VRAM, _______________________________________________ mesa-commit mailing list mesa-commit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-commit
