Module: Mesa
Branch: master
Commit: 064b84694921f82001a2431cad2eb9b94c153fb9
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=064b84694921f82001a2431cad2eb9b94c153fb9

Author: Iago Toral Quiroga <[email protected]>
Date:   Mon Feb 15 11:56:13 2021 +0100

broadcom/compiler: don't dump shader-db stats for failed shaders

Shaders that fail register allocation were dumped with an instruction
count of 0, so getting them to compile would show up as an instruction
count regression. Also, the LOST/GAINED stats depend on us not dumping
data for failed shaders, which is why we were always seeing 0/0 there.

Reviewed-by: Alejandro PiƱeiro <[email protected]>
Reviewed-by: Eric Anholt <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9077>

---

 src/broadcom/compiler/vir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/broadcom/compiler/vir.c b/src/broadcom/compiler/vir.c
index da3a0e7858e..11cd22170ae 100644
--- a/src/broadcom/compiler/vir.c
+++ b/src/broadcom/compiler/vir.c
@@ -1210,7 +1210,7 @@ v3d_prog_data_size(gl_shader_stage stage)
 int v3d_shaderdb_dump(struct v3d_compile *c,
                      char **shaderdb_str)
 {
-        if (c == NULL)
+        if (c == NULL || c->compilation_result != V3D_COMPILATION_SUCCEEDED)
                 return -1;
 
         return asprintf(shaderdb_str,

_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to