Module: Mesa Branch: master Commit: 8bcda472a05c047a507b9d1b4a59d4f16a89c5d2 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8bcda472a05c047a507b9d1b4a59d4f16a89c5d2
Author: Iago Toral Quiroga <[email protected]> Date: Mon Mar 8 10:07:28 2021 +0100 broadcom/compiler: add an additional sanity check assert to the ldvary fixup Reviewed-by: Alejandro Piñeiro <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9471> --- src/broadcom/compiler/qpu_schedule.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/broadcom/compiler/qpu_schedule.c b/src/broadcom/compiler/qpu_schedule.c index bc0ade2cbf0..9283b936ccc 100644 --- a/src/broadcom/compiler/qpu_schedule.c +++ b/src/broadcom/compiler/qpu_schedule.c @@ -1659,6 +1659,15 @@ fixup_pipelined_ldvary(struct v3d_compile *c, inst->sig_magic = false; inst->sig_addr = 0; + /* By moving ldvary to the previous instruction we make it update + * r5 in the current one, so nothing else in it should write r5. + * This should've been prevented by our depedency tracking, which + * would not allow ldvary to be paired up with an instruction that + * writes r5 (since our dependency tracking doesn't know that the + * ldvary write r5 happens in the next instruction). + */ + assert(!v3d_qpu_writes_r5(c->devinfo, inst)); + return true; } _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
