Module: Mesa
Branch: master
Commit: d411691965a2b5c97a81a14e88fc82542b6eade9
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=d411691965a2b5c97a81a14e88fc82542b6eade9

Author: Michel Dänzer <[email protected]>
Date:   Tue Mar  9 11:53:09 2021 +0100

aco/tests: Use _exit in child process

Since the child process doesn't call exec(), exit() attempted to run
atexit handlers registered by the parent process. This could result in
the child process hanging in exit() if there were still disk cache
threads alive when the parent process called fork(). (The CI runners
hit this multiple times when running tests in strace)

Fixes: 6a246f5c6d51 "aco/tests: Fix deadlock for too large test lists"
Reviewed-by: Tony Wasserka <[email protected]>
Reviewed-by: Adam Jackson <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9472>

---

 src/amd/compiler/tests/main.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/compiler/tests/main.cpp b/src/amd/compiler/tests/main.cpp
index e8bc2973f32..e0abf63b525 100644
--- a/src/amd/compiler/tests/main.cpp
+++ b/src/amd/compiler/tests/main.cpp
@@ -195,7 +195,7 @@ int check_output(char **argv)
       write(stdin_pipe[1], checker_stdin_data, checker_stdin_size);
       close(stdin_pipe[0]);
       close(stdin_pipe[1]);
-      exit(0);
+      _exit(0);
    }
 }
 

_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to