Module: Mesa Branch: main Commit: dc2c9bae250f5db45e43fb492d290f63d1c43d7d URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dc2c9bae250f5db45e43fb492d290f63d1c43d7d
Author: Jason Ekstrand <[email protected]> Date: Wed Mar 30 11:49:41 2022 -0500 vulkan: Add more VU comments to justify framebuffer asserts Reviewed-by: Lionel Landwerlin <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15674> --- src/vulkan/runtime/vk_render_pass.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/vulkan/runtime/vk_render_pass.c b/src/vulkan/runtime/vk_render_pass.c index 15c9259273e..6780baf75de 100644 --- a/src/vulkan/runtime/vk_render_pass.c +++ b/src/vulkan/runtime/vk_render_pass.c @@ -1754,6 +1754,16 @@ vk_common_CmdBeginRenderPass2(VkCommandBuffer commandBuffer, struct vk_attachment_state *att_state = &cmd_buffer->attachments[a]; /* From the Vulkan 1.3.204 spec: + * + * VUID-VkFramebufferCreateInfo-pAttachments-00880 + * + * "If renderpass is not VK_NULL_HANDLE and flags does not include + * VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT, each element of pAttachments + * must have been created with a VkFormat value that matches the + * VkFormat specified by the corresponding VkAttachmentDescription in + * renderPass" + * + * and * * VUID-VkRenderPassBeginInfo-framebuffer-03216 * @@ -1768,6 +1778,16 @@ vk_common_CmdBeginRenderPass2(VkCommandBuffer commandBuffer, assert(image_view->format == pass_att->format); /* From the Vulkan 1.3.204 spec: + * + * VUID-VkFramebufferCreateInfo-pAttachments-00881 + * + * "If renderpass is not VK_NULL_HANDLE and flags does not include + * VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT, each element of pAttachments + * must have been created with a samples value that matches the + * samples value specified by the corresponding + * VkAttachmentDescription in renderPass" + * + * and * * UID-VkRenderPassBeginInfo-framebuffer-03217 *
