Module: Mesa
Branch: main
Commit: 9a67edaa56818a324118607c976528430b96e7c2
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=9a67edaa56818a324118607c976528430b96e7c2

Author: Samuel Pitoiset <[email protected]>
Date:   Wed Aug 31 11:00:10 2022 +0200

radv: reword a comment about dynamic states when rasterization is disabled

Make it more generic instead of listing all states.

Signed-off-by: Samuel Pitoiset <[email protected]>
Reviewed-by: Timur Kristóf <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18344>

---

 src/amd/vulkan/radv_pipeline.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index 108cbbe43a0..46e445f601f 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -1367,11 +1367,7 @@ radv_pipeline_needed_dynamic_state(const struct 
radv_graphics_pipeline *pipeline
                   RADV_DYNAMIC_PRIMITIVE_RESTART_ENABLE | 
RADV_DYNAMIC_PRIMITIVE_TOPOLOGY);
    }
 
-   /* If rasterization is disabled we do not care about any of the
-    * dynamic states, since they are all rasterization related only,
-    * except primitive topology, primitive restart enable, vertex
-    * binding stride and rasterization discard itself.
-    */
+   /* Disable dynamic states that are useless when rasterization is disabled. 
*/
    if (!raster_enabled) {
       return RADV_DYNAMIC_PRIMITIVE_TOPOLOGY | 
RADV_DYNAMIC_VERTEX_INPUT_BINDING_STRIDE |
              RADV_DYNAMIC_PRIMITIVE_RESTART_ENABLE | 
RADV_DYNAMIC_RASTERIZER_DISCARD_ENABLE |

Reply via email to