Module: Mesa Branch: main Commit: 96054f8ebaf5348b3270f984e419f381b5a6c52d URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=96054f8ebaf5348b3270f984e419f381b5a6c52d
Author: Kenneth Graunke <[email protected]> Date: Tue May 24 01:59:42 2022 -0700 iris: Use nir_intrinsic_load_global_constant for large constants We were using the old load_global intrinsic still, which can't be reordered, limiting optimization opportunities. We know the data here is constant, so we can use the newer load_global_constant intrinsic. This doesn't seem to have any impact on shader-db or fossil-db on any Intel platform. Reviewed-by: Emma Anholt <[email protected]> Reviewed-by: Ian Romanick <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16539> --- src/gallium/drivers/iris/iris_program.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/iris/iris_program.c b/src/gallium/drivers/iris/iris_program.c index 4d909b8bb01..69d9ddc1e41 100644 --- a/src/gallium/drivers/iris/iris_program.c +++ b/src/gallium/drivers/iris/iris_program.c @@ -534,11 +534,11 @@ iris_setup_uniforms(const struct brw_compiler *compiler, nir_load_reloc_const_intel(&b, BRW_SHADER_RELOC_CONST_DATA_ADDR_HIGH)); nir_ssa_def *data = - nir_load_global(&b, nir_iadd(&b, const_data_base_addr, - nir_u2u64(&b, offset)), - load_align, - intrin->dest.ssa.num_components, - intrin->dest.ssa.bit_size); + nir_load_global_constant(&b, nir_iadd(&b, const_data_base_addr, + nir_u2u64(&b, offset)), + load_align, + intrin->dest.ssa.num_components, + intrin->dest.ssa.bit_size); nir_ssa_def_rewrite_uses(&intrin->dest.ssa, data);
