Module: Mesa Branch: main Commit: ad8c0878b4a6327adf24a2d42bae501b9f99d342 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ad8c0878b4a6327adf24a2d42bae501b9f99d342
Author: Karmjit Mahil <[email protected]> Date: Tue Nov 29 16:08:03 2022 +0000 pvr: Update comment about ZS and MSAA buffers for pvrsrvkm submission. Signed-off-by: Karmjit Mahil <[email protected]> Reviewed-by: Frank Binns <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21102> --- src/imagination/vulkan/winsys/pvrsrvkm/pvr_srv_job_render.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/imagination/vulkan/winsys/pvrsrvkm/pvr_srv_job_render.c b/src/imagination/vulkan/winsys/pvrsrvkm/pvr_srv_job_render.c index 64e9f4348b3..4b56c4a7512 100644 --- a/src/imagination/vulkan/winsys/pvrsrvkm/pvr_srv_job_render.c +++ b/src/imagination/vulkan/winsys/pvrsrvkm/pvr_srv_job_render.c @@ -766,6 +766,12 @@ VkResult pvr_srv_winsys_render_submit( sync_prim->value++; do { + /* The fw allows the ZS and MSAA scratch buffers to be lazily allocated in + * which case we need to provide a status update (i.e. if they are + * physically backed or not) to the fw. In our case they will always be + * physically backed so no need to inform the fw about their status and + * pass in anything. We'll just pass in NULL. + */ result = pvr_srv_rgx_kick_render2(srv_ws->render_fd, srv_ctx->handle, 0, @@ -808,9 +814,7 @@ VkResult pvr_srv_winsys_render_submit( false, 0, rt_data_handle, - /* Currently no support for PRs. */ NULL, - /* Currently no support for PRs. */ NULL, 0, NULL,
