Module: Mesa Branch: main Commit: 5b01a0ac47778177aab87478ccc1a342f9ebd5d2 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5b01a0ac47778177aab87478ccc1a342f9ebd5d2
Author: Nanley Chery <[email protected]> Date: Mon May 1 11:54:20 2023 -0700 anv: Drop the MCS initialization performance warning The comment above the warning explains that not all bit patterns are necessarily valid. While we're at it, fix a typo in that comment. Reviewed-by: Ivan Briano <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22545> --- src/intel/vulkan/genX_cmd_buffer.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 8a2dae5815c..c15b62dd809 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@ -1090,8 +1090,8 @@ transition_color_buffer(struct anv_cmd_buffer *cmd_buffer, * * For MCS, (2) is never an issue because we don't support multisampled * storage images. In theory, issue (1) is a problem with MCS but we've - * never seen it in the wild. For 4x and 16x, all bit patters could, in - * theory, be interpreted as something but we don't know that all bit + * never seen it in the wild. For 4x and 16x, all bit patterns could, + * in theory, be interpreted as something but we don't know that all bit * patterns are actually valid. For 2x and 8x, you could easily end up * with the MCS referring to an invalid plane because not all bits of * the MCS value are actually used. Even though we've never seen issues @@ -1133,12 +1133,6 @@ transition_color_buffer(struct anv_cmd_buffer *cmd_buffer, } } } else { - if (image->vk.samples == 4 || image->vk.samples == 16) { - anv_perf_warn(VK_LOG_OBJS(&image->vk.base), - "Doing a potentially unnecessary fast-clear to " - "define an MCS buffer."); - } - /* If will_full_fast_clear is set, the caller promises to fast-clear * the largest portion of the specified range as it can. */
