Module: Mesa
Branch: main
Commit: b56c2885890b6aca39dbdb65229f06acaf0e9560
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=b56c2885890b6aca39dbdb65229f06acaf0e9560

Author: Samuel Pitoiset <[email protected]>
Date:   Thu Aug  3 15:09:05 2023 +0200

radv: remove redundant check in radv_cmd_buffer_after_draw()

RADV_CMD_FLAG_PS_PARTIAL_FLUSH is only used for draws with
RADV_DEBUG=syncshaders, which implies a valid graphics pipeline.

Signed-off-by: Samuel Pitoiset <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24473>

---

 src/amd/vulkan/radv_cmd_buffer.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 01f1fc3cab6..53c9640c5da 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -731,8 +731,7 @@ radv_cmd_buffer_after_draw(struct radv_cmd_buffer 
*cmd_buffer, enum radv_cmd_flu
                              radv_cmd_buffer_uses_mec(cmd_buffer), flags, 
&sqtt_flush_bits,
                              cmd_buffer->gfx9_eop_bug_va);
 
-      if (cmd_buffer->state.graphics_pipeline && (flags & 
RADV_CMD_FLAG_PS_PARTIAL_FLUSH) &&
-          radv_cmdbuf_has_stage(cmd_buffer, MESA_SHADER_TASK)) {
+      if ((flags & RADV_CMD_FLAG_PS_PARTIAL_FLUSH) && 
radv_cmdbuf_has_stage(cmd_buffer, MESA_SHADER_TASK)) {
          /* Force wait for compute engines to be idle on the internal cmdbuf. 
*/
          si_cs_emit_cache_flush(device->ws, cmd_buffer->gang.cs, 
device->physical_device->rad_info.gfx_level, NULL, 0,
                                 true, RADV_CMD_FLAG_CS_PARTIAL_FLUSH, 
&sqtt_flush_bits, 0);

Reply via email to