URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=52ab5584b870be041b93f702693ea3f5665df860
Author: Eric Engestrom <[email protected]>
Date: Wed Oct 4 14:59:30 2023 +0100
docs: add sha256sum for 23.1.9
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=acb5ee278ac11b1da44c9f9e64c43389e606403b
Author: Eric Engestrom <[email protected]>
Date: Wed Oct 4 14:53:02 2023 +0100
VERSION: bump for 23.1.9
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=92b593fef1a1dd1e184baba00a83c1ab4dbc1972
Author: Eric Engestrom <[email protected]>
Date: Wed Oct 4 14:52:56 2023 +0100
docs: add release notes for 23.1.9
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=0994aaaf51277598cfdc6fe8ea4e8f50f34bfd51
Author: Danylo Piliaiev <[email protected]>
Date: Thu Jul 27 14:38:43 2023 +0200
radv: fix unused non-xfb shader outputs not being removed
It was not taken into account that without Offset decoration
the output is not written into XFB.
Aside from eliminating more outputs this change prevents gl_PerVertex
builtins generated by glslang from being kept alive in case when XFB
is enabled. Keeping such outputs alive may upset a driver.
VUID-StandaloneSpirv-Offset-04716:
"Only variables or block members in the output interface decorated
with Offset can be captured for transform feedback, and those
variables or block members must also be decorated with XfbBuffer
and XfbStride, or inherit XfbBuffer and XfbStride decorations from
a block containing them"
Additional info about glslang behavior could be found at:
https://github.com/KhronosGroup/glslang/issues/1526
Fixes: e95531e101f0ba61d28195fe38414e411bf418b3
("radv: fix gathering XFB info if there is dead outputs")
Signed-off-by: Danylo Piliaiev <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24318>
(cherry picked from commit 81407797b940dc97da808cde2f19fb59267d1f81)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=1f42a7004ca43c6394250f34f0aabc2cde992757
Author: Mike Blumenkrantz <[email protected]>
Date: Mon Sep 25 15:30:11 2023 -0400
zink: fix crashing in image rebinds
this is invalid for buffer textures
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25379>
(cherry picked from commit c3f5416eaf3c080856b369632a1987511e214a46)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=5ab99743c0cb469c863da6c5faad55c5b59d88f6
Author: Gert Wollny <[email protected]>
Date: Mon Oct 2 15:38:19 2023 +0200
copyimage: check requested slice early when cube maps are involved
The generalized check for the z-slice happens in 'check_region_bounds',
but this function requires the image pointer that is acquired in
`prepare_target_err`, therefore replace the assertion with a proper test.
v2: Also check for negative value (Brian Paul)
CC: mesa-stable
Signed-off-by: Gert Wollny <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25507>
(cherry picked from commit 16662f8d3a57458325bd5381910722f67699fea6)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=9fa7e28179b758be97fb008024e46ab82a2194bf
Author: Danylo Piliaiev <[email protected]>
Date: Thu Aug 10 15:36:33 2023 +0200
tu/kgsl: Fix memory leak of tmp allocations during submissions
cc: mesa-stable
Signed-off-by: Danylo Piliaiev <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12805>
(cherry picked from commit 3ccd199708e5fd8c0d3cd4d266f88cbad3c1fa3d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=15524986b8131371a900f2696276b8167ae7822c
Author: Christian Gmeiner <[email protected]>
Date: Wed Aug 30 17:12:16 2023 +0200
isaspec: encode: Correct used regex
The current regex misses the = sign and therefore fails to match
DST:align=16.
Fixes: 9e56f69edf5 ("isaspec: encode: handle special fieldname properties")
Signed-off-by: Christian Gmeiner <[email protected]>
Reviewed-by: Rob Clark <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25451>
(cherry picked from commit ef602e77f676ba71606f99c99df4a389d9fb65dc)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=3f3b84c423efbd1a85c279157e18856457c079a9
Author: Tapani Pälli <[email protected]>
Date: Tue Sep 26 12:25:42 2023 +0300
iris: flush data cache when flushing HDC on GFX < 12
This matches what anv driver does.
Fixes: a969ad1d ("iris: Demote DC flush to HDC flush in cache tracker")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6314
Signed-off-by: Tapani Pälli <[email protected]>
Acked-by: Lionel Landwerlin <[email protected]>
Reviewed-by: Kenneth Graunke <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25399>
(cherry picked from commit c02db0d90ff749977170163479c06a87429de942)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=937780976f8a83a1ead909eb26c19e1737b3c150
Author: Eric Engestrom <[email protected]>
Date: Wed Oct 4 10:09:54 2023 +0100
.pick_status.json: Mark 2be9b66cddbe56136adb95013f084b3d881b8b71 as
denominated
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=747cebac9930fdc280d260ca8ec2a034fe8df21c
Author: Eric Engestrom <[email protected]>
Date: Wed Oct 4 10:08:14 2023 +0100
.pick_status.json: Mark a0fba1731193c2475843ab704a2b053abdcaab43 as
denominated
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=f85e2d9d007c05d66a88b1a55dad6b12a07feb96
Author: Marek Olšák <[email protected]>
Date: Fri Sep 1 22:45:05 2023 -0400
ac/llvm: fix flat PS input corruption
Fixes: 0a54fbb5b40fc4e4a - radeonsi/gfx11: interp changes for 32bit
Reviewed-by: Timur Kristóf <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25492>
(cherry picked from commit c7e08acd1283678a8f8ea3881b08ad97ea773d7e)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=0b12cfb2bab2242b050f5ea90c99fb05bb89bafa
Author: Prodea Alexandru-Liviu <[email protected]>
Date: Tue Jun 27 17:32:57 2023 +0000
microsoft/clc: Don't build compiler test if build-tests is false
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8161
Cc: mesa-stable
Reviewed-by: Eric Engestrom <[email protected]>
Reviewed-by: Jesse Natalie <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23890>
(cherry picked from commit 5acbadddb454505b2cc354f9a9a33ce289f489fa)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=39d7fb6f5e0bbbf7e4cf0de6273617e43544690c
Author: Eric Engestrom <[email protected]>
Date: Wed Oct 4 09:39:33 2023 +0100
.pick_status.json: Update to a2641ddf0dfba68f957e4d7d839d7b5bbd02aa62
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=abd7c9b30351faeb0a56c5034aaf37c5046eb113
Author: Eric Engestrom <[email protected]>
Date: Mon Oct 2 09:40:28 2023 +0100
.pick_status.json: Update to 6ea2ea0bb0e04ee658ed8ebb4e51515b2f4d20fb
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a09d1b471280722260ded7dd8f61d9097d3f996d
Author: Mike Blumenkrantz <[email protected]>
Date: Fri Sep 29 09:15:31 2023 -0400
radv: fix external handle type queries for dmabuf/fd
the intent of the VkExternalMemoryProperties API is that all compatible
handle types are returned, not just the type being queried. these two
types are compatible, so return both when both are supported
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25474>
(cherry picked from commit a524f6b5d4fb04716a4d3c0e0f9014175e633595)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=016a34ded5ee4c146fbe095f9b31dede58beb366
Author: Samuel Pitoiset <[email protected]>
Date: Tue Sep 26 18:19:59 2023 +0200
radv: fix COMPUTE_SHADER_INVOCATIONS query on compute queue
The VA needs to be adjusted, otherwise the hw always writes at offset 0.
This fixes dEQP-VK.query_pool.statistics_query.*_cq.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25406>
(cherry picked from commit a9945216ba223d57ade453d5f855edd93dd3b200)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=aa3f6b7926c707ae88e450177190f7ddf16fb8f5
Author: Samuel Pitoiset <[email protected]>
Date: Wed Jul 19 09:12:01 2023 +0200
radv: simplify the NGG vs legacy pipelinestat query path
NGG is enabled by default on RDNA1-2 but the driver might fallback to
legacy GS for some reasons, like XFB. On these generations, the number
of generated primitives by GS needs to be emulated from the NGG shader
because the hw doesn't increment the related pipelinestat counter.
In order to support NGG and legacy GS with that query (remember that
we can't know pipelines when starting/ending queries), we used to
reserve 2x 64-bit counters to store the GDS results, and the results
were accumulated.
Now that legacy GS also uses GDS counters, we can simplify this path
and overwrite the pipelinestat counter directly instead of having two
separate counters.
Signed-off-by: Samuel Pitoiset <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24231>
(cherry picked from commit 50709863ace6ccd003389b595af20536980f6a3e)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=32609de1da8658c553f14ee4a6c55116a05e9495
Author: Samuel Pitoiset <[email protected]>
Date: Tue Sep 26 16:37:28 2023 +0200
radv: stop skip emitting CB states when there is no color attachment
This is actually wrong. For example, if there is a DCC decompress
draw followed by a draw without any color attachments,
CB_COLOR_CONTROL.MODE is still CB_DCC_DECOMPRESS but it should be
CB_DISABLED. For some reasons, this hangs on RDNA3 (VM faults are also
reported through dmesg).
This fixes GPU hangs with Resident Evil 6, Star Wars The Old Republic
and probably more games on RDNA3.
Strictly speaking, I don't think this dynamic state optimization is
worth a try, even for other states, and I think it would be safer to
remove it completely.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9335
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8327
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9878
Fixes: c08082e8615 ("radv: ignore all CB dynamic states when there is no
color attachments")
Signed-off-by: Samuel Pitoiset <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25402>
(cherry picked from commit af2a96bb37b099067adb490d189399b46324b46f)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=757709dc878b421003b79189fb546b985854c7bb
Author: Mike Blumenkrantz <[email protected]>
Date: Wed Sep 27 14:43:09 2023 -0400
glx: XFree visual info
cc: mesa-stable
Reviewed-by: Tapani Pälli <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25441>
(cherry picked from commit 441e57048b4e0b09effad202ba4a5c8f8b08131a)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a77ac552ea5092153052d99361e879bf7f2521f8
Author: antonino <[email protected]>
Date: Thu Aug 17 15:09:15 2023 +0200
vulkan: Handle vkSetDebugUtilsObjectNameEXT on WSI objects
Some WSI objects don't extend `vk_object_base` therefore they need
special handling.
Fixes: 3c87618d357 ("vulkan: Handle vkGet/SetPrivateDataEXT on Android
swapchains")
Reviewed-by: Lionel Landwerlin <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24752>
(cherry picked from commit 76d150674bdcd1a79e66552c5e8bc148ce7dc14c)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=94af1fc5611f207c7c9d422f0e7b902221d1f01a
Author: antonino <[email protected]>
Date: Thu Aug 17 15:07:04 2023 +0200
vulkan: Extend vkGet/SetPrivateDataEXT handling to VkSurface
VkSurface is handled by WSI and it doesn't extend `vk_object_base` so it
needs special handling.
Fixes: 3c87618d357 ("vulkan: Handle vkGet/SetPrivateDataEXT on Android
swapchains")
Reviewed-by: Lionel Landwerlin <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24752>
(cherry picked from commit 5fe289d74158a93bdac0dad6cc410f6585f0ae3d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ec4c6f87a45728d8f2e70dac58dfc137d4d0d703
Author: antonino <[email protected]>
Date: Thu Aug 17 15:06:18 2023 +0200
vulkan: Extend vkGet/SetPrivateDataEXT handling to all platforms
Non-android platforms use mesa WSI, however some WSI object still don't
extend `vk_object_base` so they still need special handling.
Fixes: 3c87618d357 ("vulkan: Handle vkGet/SetPrivateDataEXT on Android
swapchains")
Reviewed-by: Lionel Landwerlin <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24752>
(cherry picked from commit 710d4780663aac597d88364a76e828bcbf1c7e8e)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=415f2a6a9c95f4ad5bd5c532b4b290a2d341f4eb
Author: wangra <[email protected]>
Date: Wed Sep 27 13:11:00 2023 -0400
tu/kgsl: Fix bitfield of DITHER_MODE_MRT6
The enum `adreno_rb_dither_mode` needs 2 bits, change the `high` to 13 to
make sure 2 bits are used for `DITHER_MODE_MRT6`
Fixes: e03259974e2f2c8e8c0295f8dab56d88e7bd896c ("freedreno: Generate
headers from xml files")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25439>
(cherry picked from commit e90f9d8e212535fbd44bb4088fb0e8078d9f2935)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=04a8cc5c517ae2a963185afbfdaf58a445b8d785
Author: Lionel Landwerlin <[email protected]>
Date: Wed Sep 27 15:42:32 2023 +0300
iris: add missing workaround for 3DSTATE_LINE_STIPPLE
Signed-off-by: Lionel Landwerlin <[email protected]>
Cc: mesa-stable
Reviewed-by: Tapani Pälli <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25425>
(cherry picked from commit ee4062666c625faa5026e5d076681c7a2ad1da6d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=140c7ab73d8ed4acba7825ca1a1a811829039bb3
Author: Georg Lehmann <[email protected]>
Date: Tue Sep 26 18:29:31 2023 +0200
aco: implement 64bit div find_lsb
This can be selected for divergent subgroupBallotFindLSB.
Reviewed-by: Rhys Perry <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25407>
(cherry picked from commit b91616e80049d8de911cda06874d1d26255bafe8)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=c7b62757aa0946e2df0dbe6ce89c352683ff7380
Author: Georg Lehmann <[email protected]>
Date: Tue Sep 26 17:13:12 2023 +0200
aco: fix p_extract with v1 dst and s1 operand
Reviewed-by: Rhys Perry <[email protected]>
Fixes: f14023666ca ("aco: Allow p_extract to have different definition and
operand sizes.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25403>
(cherry picked from commit 4ea611bca02c4e5ff783e73476d7b8f63766696e)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=02e77eeb2eb640a8c66e02062f2bd31be0f435dc
Author: Konstantin Seurer <[email protected]>
Date: Tue Aug 15 14:55:10 2023 +0200
aco/spill: Make sure that offset stays in bounds
If a shader spills a lot, the offset can be above the HW limit.
cc: mesa-stable
Reviewed-by: Rhys Perry <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24652>
(cherry picked from commit 24555cdbbd93cd0eb56d7da7cc60dc43adc9b9f1)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=15da4bc4de515c62e1a8e9c0e4be7ed379486a2c
Author: Eric Engestrom <[email protected]>
Date: Sat Sep 30 09:09:22 2023 +0100
.pick_status.json: Update to e7d393b1d7b8fd9b39942d4c2e5b32c46ffffff7
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=3aa5e03ca101c64584d1f1d63c32eb8282602574
Author: Rhys Perry <[email protected]>
Date: Fri Sep 29 11:01:45 2023 +0100
aco/optimizer_postRA: don't combine DPP across exec on GFX8/9
GFX8/9 seem to use FI=0 behaviour.
fossil-db (vega10):
Totals from 1 (0.00% of 63053) affected shaders:
Instrs: 542 -> 570 (+5.17%)
CodeSize: 2928 -> 3040 (+3.83%)
Latency: 2087 -> 2118 (+1.49%)
InvThroughput: 1103 -> 1143 (+3.63%)
Affected shader is from Cyberpunk 2077 fossil.
Signed-off-by: Rhys Perry <[email protected]>
Reviewed-by: Georg Lehmann <[email protected]>
Cc: 23.2 <mesa-stable>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9784
(cherry picked from commit e64f895e08f39e0f2c42df1f2aac9f92f94cefd1)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25479>
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=444dda215e0707b0a4e03b45cd57c49fac34a3f2
Author: Eric Engestrom <[email protected]>
Date: Wed Sep 27 12:26:14 2023 +0100
.pick_status.json: Mark 6d00c2f78cf651ef156c287368783ac6d0c40d50 as
denominated
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=6489f6464b6c284bf92a7467c62bb0fca0c8f0a7
Author: Dave Airlie <[email protected]>
Date: Tue Sep 26 11:40:18 2023 +1000
llvmpipe: reset viewport_index_slot in fb bind
I hit a problem running a set of lvp caselists with
dEQP-VK.transform_feedback.simple.draw_indirect_endqueryindexed_streamid_0_16,Crash
This was crashing due to
assert(setup->viewport_index_slot < 0);
in try_update_scene_state
This was because a previous draw had set viewport index slot to 2,
but a clear then draw sequence never resets it, so the clear gets
a scene, and when the subsequent flush happens for that scene,
the viewport_index_slot is never updated. It only gets updated on
draws.
This just resets it as lp_setup_update_state will always pick up
the correct one for the next draw.
Cc: mesa-stable
Reviewed-by: Roland Scheidegger <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25387>
(cherry picked from commit 8791aab20f21bf206cbd187840fea327a5942af5)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=563b08c2bea6f4043ecc105ddc4c9109c32b65df
Author: Konrad Dybcio <[email protected]>
Date: Mon Sep 25 18:28:27 2023 +0200
freedreno: Include speedbin fallback in 690 chipid to fix probing
The kernel exposes CHIP_ID, which consists of:
[63:48] const 0 / reserved
[47:32] speedbin (default 0xffff)
[31:0 ] actual gpu chip ID
Fix the 690 chip id to make it probe correctly.
Keep the existing entry for the downstream KGSL driver.
This is essentially the same as Commit 6067aba9e6db ("freedreno: Include
speedbin fallback in 740 chipid to fix probing"), except for the older
core.
Fixes: 210c6c11cc61 ("freedreno+tu: Add a690 support")
Signed-off-by: Konrad Dybcio <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25408>
(cherry picked from commit b4d111ab6c88573e2b54d1b0460e474306d5e2eb)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=8e8acb4481657f4fcd6cc1a9a76e762a9e14da60
Author: Karol Herbst <[email protected]>
Date: Tue Sep 26 13:52:29 2023 +0200
meson/rusticl: add sha1_h
This ensures this file is generated.
Fixes: 20c90fed5a0 ("rusticl: added")
Signed-off-by: Karol Herbst <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25400>
(cherry picked from commit 2a90ee16935cf3c681cb4f993a9b7b1249a0750f)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=dcfa7b970f67b72fccb3259128bd2af6a368e51c
Author: Kenneth Graunke <[email protected]>
Date: Mon Sep 18 17:43:01 2023 -0700
mesa: Fix zeroing of new ParameterValues array entries when growing
On non-Windows OSes, align_realloc is the os_realloc_aligned() from
src/util/os_memory_aligned.h, which doesn't use realloc internally.
Instead, it uses os_malloc_aligned() and memcpy's over the old data,
which is why it needs an "old size" (unlike normal realloc).
In _mesa_reserve_parameter_storage, the call to align_realloc above
passes (oldValNum * sizeof(gl_constant_value)) as the old size, which
is all the actual data. The actual allocation size of the array may
be larger (in fact, we allocate 16 extra components), which is tracked
in SizeValues. After realloc, we memset to zero starting at the old
allocation size, to the new allocation size.
This would work if it were a real realloc. However, because we actually
malloc + memcpy and only copy the previous /data/, not the allocated
size, and then memset from the old /allocated size/, our new copy will
have the spaces between the old data and the old allocation size neither
copied nor memset, leaving them as uninitialized garbage memory.
These values then get written to the shader cache, meaning that if you
compile the same shader multiple times, you may get different shader
cache entries. This is bad for reproducible, deterministic compiles.
While at it, we also memset to zero in _mesa_add_parameter, as this
looks like another place where memset-to-zero is missing.
To reproduce this error, one can run shader-db:
$ MESA_SHADER_CACHE_DIR=a ./run -b shaders/godot3.4/49-28.shader_test
$ MESA_SHADER_CACHE_DIR=b ./run -b shaders/godot3.4/49-28.shader_test
and see an occasional difference in the end of the ParameterValues
array, where there's a padding gap between the last two elements that
was never zero-initialized.
Thanks to Mark Janes for discovering this and tracking it down together!
Cc: mesa-stable
Reviewed-by: Mark Janes <[email protected]>
Reviewed-by: Ian Romanick <[email protected]>
Reviewed-by: Marek Olšák <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25316>
(cherry picked from commit 1c1aa579ff5214a2082ad29ef99d76b52d76d560)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=8d227f1420d799a74a44d80eb51c95ad142b5cad
Author: Tapani Pälli <[email protected]>
Date: Mon Sep 25 15:15:05 2023 +0300
anv: fix a leak of fp64_nir shader
Fixes: 8c4c4c3ee1a2 ("anv: Add softtp64 workaround")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9846
Signed-off-by: Tapani Pälli <[email protected]>
Reviewed-by: Lionel Landwerlin <[email protected]>
Reviewed-by: Sagar Ghuge <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25372>
(cherry picked from commit 31883b1f5ea3446d193fcd1a69a963a0f851a9e3)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=254ba0ecd3e73cb866bd13de5d759c42e5bd64a8
Author: Lionel Landwerlin <[email protected]>
Date: Fri Aug 25 23:42:17 2023 +0300
intel: don't assume Linux minor dev node
Signed-off-by: Lionel Landwerlin <[email protected]>
Cc: mesa-stable
Acked-by: Emma Anholt <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24744>
(cherry picked from commit a851dc5e3c08763151d110aab5f58949e9ce4d3f)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=c0f993008961386206e196c88b023ef5806d2427
Author: David Rosca <[email protected]>
Date: Sat Sep 23 15:49:55 2023 +0200
frontends/va: Set default rate control values once when creating encoder
Move setting the default values from getEncParamPresetH264/5 as this
function is called on each frame which would result in overwriting
values set by application.
This fixes setting HRD parameters and max_qp/min_qp when
PIPE_VIDEO_CAP_ENC_QUALITY_LEVEL is not supported.
Cc: mesa-stable
Reviewed-by: Ruijing Dong <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25355>
(cherry picked from commit dd2ef9a0e4c706e3139f48d16fc8a617e58717d0)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=58f52f8b4e12daf1d691488fb5613e48873c7f86
Author: David Rosca <[email protected]>
Date: Sat Sep 23 13:11:57 2023 +0200
frontends/va: Process VAEncSequenceParameterBufferType first in
vaRenderPicture
The encoder is created in handleVAEncSequenceParameterBufferType and it
also sets some default parameters, so we need to make sure to handle
this buffer first because application may have already set those
parameters from earlier buffers.
This fixes setting HRD parameters with gstreamer vah264enc/vah265enc
when PIPE_VIDEO_CAP_ENC_QUALITY_LEVEL is supported.
Cc: mesa-stable
Reviewed-by: Ruijing Dong <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25355>
(cherry picked from commit c970a9b6634d22d8b9b7567aff8708dc58ba9e81)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=61129036fe77ce905e9099f16dc9df4e0208f418
Author: Karmjit Mahil <[email protected]>
Date: Tue Sep 19 13:35:50 2023 +0100
pvr: Fix dynamic desc offset storage
The index at which the dynamic descriptor offsets were being
stored was incorrect, leading to some offsets not being stored and
thus `0` being applied as the offset to the descriptors instead.
dEQP test fixed:
dEQP-VK.binding_model.shader_access.{primary,secondary}_cmd_buf
.uniform_buffer_dynamic
.{vertex,fragment,compute,vertex_fragment}
.multiple_discontiguous_descriptor_sets
.*_descriptor.offset_view_{,non}zero_dynamic_nonzero
Fixes: aa791961a82e ("pvr: Add support for dynamic buffers descriptors")
Signed-off-by: Karmjit Mahil <[email protected]>
Reviewed-by: Frank Binns <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25320>
(cherry picked from commit feafb8a256b67d816c1cb8fdf258c75a29245c3f)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=053cbf4471270b902265c0c1b56126f8e3e14915
Author: Mike Blumenkrantz <[email protected]>
Date: Wed Aug 16 06:41:48 2023 -0400
zink: always trace_screen_unwrap in acquire
it's possible for acquire to be called from the frontend, in which
case the screen will still be trace-wrapped
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25288>
(cherry picked from commit 207b37bfd9b773043819c2cea6eaf57557bba57d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=81e6a108dab956b9de2214435e6fbdbc46b46293
Author: Mike Blumenkrantz <[email protected]>
Date: Tue Sep 19 08:53:42 2023 -0400
zink: avoid UAF on wayland async present with to-be-retired swapchain
wayland surfaces are likely to become unlinked in WSI implementations upon
retiring a swapchain, requiring the pending present to complete
in order to avoid invalid access
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25288>
(cherry picked from commit aaabb5b0f209dfad32ff108a49f39871e688444f)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=4a5788e6a3238da823d29f0ed5cf0cdb21aeea3f
Author: Mike Blumenkrantz <[email protected]>
Date: Tue Sep 19 09:01:45 2023 -0400
zink: move swapchain fence to swapchain object
this is more accurate in terms of usage/ownership and avoids potential
illegal fence usage in the scenario where multiple async presents are
in flight
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25288>
(cherry picked from commit 2b7b1059e418359c6445833e12dea27842810cc6)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=df00f802d8b3d2bbec883f6ad2bbc57797953bfd
Author: Pierre-Eric Pelloux-Prayer <[email protected]>
Date: Thu Sep 21 09:42:53 2023 +0200
radeonsi: emit framebuffer state after allocating cmask
tex->cmask_base_address_reg and tex->cb_color_info are used in
si_emit_framebuffer_state so we have to re-emit the state when
they're modified.
It's not done in si_alloc_separate_cmask because it cannot
update framebuffer.dirty_cbufs.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9830
Cc: mesa-stable
Reviewed-by: Yogesh Mohan Marimuthu <[email protected]>
Reviewed-by: Marek Olšák <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25317>
(cherry picked from commit 60a7c9688cfb184f45ce7bcc132dc2da286ef95e)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=3c439d3b95f9caed0d5e42adbe5e420410eb5bfd
Author: Eric Engestrom <[email protected]>
Date: Wed Sep 27 12:21:06 2023 +0100
.pick_status.json: Update to 632792eca0f3befb2edec9e429e696b88001be0f
