Module: Mesa Branch: staging/23.3 Commit: 2872c824bc2ae46890b9c9ff997a3c9e514210fc URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2872c824bc2ae46890b9c9ff997a3c9e514210fc
Author: Felix DeGrood <felix.j.degr...@intel.com> Date: Tue Oct 31 23:15:37 2023 +0000 anv: remove CS_FLUSH from query regression Fixes performance regression introduced by prior refactoring of pipe control code that unnecessarily added CS_FLUSH to query start and end. Issue was diagnosed by Ben L (thank you!) Confirmed this restores performance on: * Borderlands3 +2% * Payday +3% * Factorio +3% * HogwartsLegacy +4% * Ghostrunner +7% Fixes: 6dc95685 (convert genX_query pipe controls to use pc helper) Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25983> (cherry picked from commit aa23120e4fc674d7da42c4895aa204f300155105) --- .pick_status.json | 2 +- src/intel/vulkan/genX_query.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 401ec8064bc..e9283e286a8 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1694,7 +1694,7 @@ "description": "anv: remove CS_FLUSH from query regression", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "6dc95685f3b1a14b2a0d80bc05ea198de8027f44", "notes": null diff --git a/src/intel/vulkan/genX_query.c b/src/intel/vulkan/genX_query.c index f42298f85ab..69c5ac83041 100644 --- a/src/intel/vulkan/genX_query.c +++ b/src/intel/vulkan/genX_query.c @@ -695,7 +695,7 @@ emit_query_pc_availability(struct anv_cmd_buffer *cmd_buffer, genx_batch_emit_pipe_control_write (&cmd_buffer->batch, cmd_buffer->device->info, WriteImmediateData, addr, - available, ANV_PIPE_CS_STALL_BIT); + available, 0); } /**
