Module: Mesa Branch: master Commit: f6b7157550205a0633b4c2cb49a807d581176e21 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f6b7157550205a0633b4c2cb49a807d581176e21
Author: Brian Paul <[email protected]> Date: Fri Aug 10 10:36:17 2012 -0600 mesa: raise GL_INVALID_OPERATION in glGenerateMipmap for missing base image This seems to be expected by the WebGL texture-mips test. The error makes sense, but I haven't found (yet) any OpenGL documentation specifying this error condition. See http://bugs.freedesktop.org/show_bug.cgi?id=44912 Note: This is a candidate for the 8.0 branch. Reviewed-by: José Fonseca <[email protected]> --- src/mesa/main/fbobject.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index aa8ba18..792a92d 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -2564,6 +2564,8 @@ _mesa_GenerateMipmapEXT(GLenum target) srcImage = _mesa_select_tex_image(ctx, texObj, target, texObj->BaseLevel); if (!srcImage) { _mesa_unlock_texture(ctx, texObj); + _mesa_error(ctx, GL_INVALID_OPERATION, + "glGenerateMipmap(zero size base image)"); return; } _______________________________________________ mesa-commit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-commit
