Module: Mesa Branch: 10.4 Commit: cfbc474d8024662cc67f7da990d30711e89b68a3 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cfbc474d8024662cc67f7da990d30711e89b68a3
Author: David Heidelberg <da...@ixit.cz> Date: Tue Nov 25 00:38:09 2014 +0100 st/nine: remove unused pipe_viewport_state::translate[3] and scale[3] 2efabd9f5a711a7f6cd1846630244b7814bf25b3 removed them as unused. This caused random memory overwrites (reported by Coverity). Cc: "10.4" <mesa-sta...@lists.freedesktop.org> Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> Reviewed-by: Marek Olšák <marek.ol...@amd.com> Reviewed-by: Axel Davy <axel.d...@ens.fr> Signed-off-by: David Heidelberg <da...@ixit.cz> (cherry picked from commit 90fea6b3e0153c12d8d1a0f817c56a3efa0ce99c) --- src/gallium/state_trackers/nine/nine_state.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_state.c b/src/gallium/state_trackers/nine/nine_state.c index 6924449..37de6a3 100644 --- a/src/gallium/state_trackers/nine/nine_state.c +++ b/src/gallium/state_trackers/nine/nine_state.c @@ -141,11 +141,9 @@ update_viewport(struct NineDevice9 *device) pvport.scale[0] = (float)vport->Width * 0.5f; pvport.scale[1] = (float)vport->Height * -0.5f; pvport.scale[2] = vport->MaxZ - vport->MinZ; - pvport.scale[3] = 1.0f; pvport.translate[0] = (float)vport->Width * 0.5f + (float)vport->X; pvport.translate[1] = (float)vport->Height * 0.5f + (float)vport->Y; pvport.translate[2] = vport->MinZ; - pvport.translate[3] = 0.0f; pipe->set_viewport_states(pipe, 0, 1, &pvport); } _______________________________________________ mesa-commit mailing list mesa-commit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-commit