Module: Mesa
Branch: master
Commit: 5827a1dc4b3c2f51d45f4b1d6ccd080515ed2bcc
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=5827a1dc4b3c2f51d45f4b1d6ccd080515ed2bcc

Author: Rob Clark <robcl...@freedesktop.org>
Date:   Wed May 18 09:19:00 2016 -0400

mesa/st: don't leak name

Pointed out by coverity.

Signed-off-by: Rob Clark <robcl...@freedesktop.org>

---

 src/mesa/state_tracker/st_nir_lower_builtin.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/mesa/state_tracker/st_nir_lower_builtin.c 
b/src/mesa/state_tracker/st_nir_lower_builtin.c
index b4da901..20b04d1 100644
--- a/src/mesa/state_tracker/st_nir_lower_builtin.c
+++ b/src/mesa/state_tracker/st_nir_lower_builtin.c
@@ -128,9 +128,12 @@ get_variable(lower_builtin_state *state, nir_deref_var 
*deref,
 
    char *name = _mesa_program_state_string((gl_state_index *)tokens);
 
-   nir_foreach_variable(var, &shader->uniforms)
-      if (strcmp(var->name, name) == 0)
+   nir_foreach_variable(var, &shader->uniforms) {
+      if (strcmp(var->name, name) == 0) {
+         free(name);
          return var;
+      }
+   }
 
    /* variable doesn't exist yet, so create it: */
    nir_variable *var =

_______________________________________________
mesa-commit mailing list
mesa-commit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to