Module: Mesa
Branch: master
Commit: df361fc58cb1aaf8c692c3aa6f545cf7f495b374
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=df361fc58cb1aaf8c692c3aa6f545cf7f495b374
Author: Rob Clark <robcl...@freedesktop.org>
Date: Wed May 18 11:43:15 2016 -0400
nir/validate: assume() that hashtable entry exists
At this point, it would require a logic error in nir_validate to not
have already populated this hashtable entry, but coverity doesn't
realize that:
CID 1265547 (#1 of 1): Dereference null return value (NULL_RETURNS)3.
dereference: Dereferencing a null pointer entry.
CID 1271039 (#1 of 1): Dereference null return value (NULL_RETURNS)3.
dereference: Dereferencing a null pointer entry.
Signed-off-by: Rob Clark <robcl...@freedesktop.org>
Reviewed-by: Matt Turner <matts...@gmail.com>
---
src/compiler/nir/nir_validate.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/compiler/nir/nir_validate.c b/src/compiler/nir/nir_validate.c
index b186fd5..8ac55d5 100644
--- a/src/compiler/nir/nir_validate.c
+++ b/src/compiler/nir/nir_validate.c
@@ -879,6 +879,7 @@ postvalidate_reg_decl(nir_register *reg, validate_state
*state)
{
struct hash_entry *entry = _mesa_hash_table_search(state->regs, reg);
+ assume(entry);
reg_validate_state *reg_state = (reg_validate_state *) entry->data;
nir_foreach_use(src, reg) {
@@ -955,6 +956,8 @@ postvalidate_ssa_def(nir_ssa_def *def, void *void_state)
validate_state *state = void_state;
struct hash_entry *entry = _mesa_hash_table_search(state->ssa_defs, def);
+
+ assume(entry);
ssa_def_validate_state *def_state = (ssa_def_validate_state *)entry->data;
nir_foreach_use(src, def) {
_______________________________________________
mesa-commit mailing list
mesa-commit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-commit
