Module: Mesa Branch: master Commit: 1632b0eac02cd8911c04115cb6b4693f7dcb16bb URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1632b0eac02cd8911c04115cb6b4693f7dcb16bb
Author: Rob Clark <robcl...@freedesktop.org> Date: Thu Jun 2 10:36:23 2016 -0400 freedreno: fix coverity negative array index warning Never can happen, since query would not have been created in the first place if pidx(query_type) return negative. Lets let coverity realize this. CID 1362460 Signed-off-by: Rob Clark <robcl...@freedesktop.org> --- src/gallium/drivers/freedreno/freedreno_query_hw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/freedreno/freedreno_query_hw.c b/src/gallium/drivers/freedreno/freedreno_query_hw.c index 2ac03f2..04452ef 100644 --- a/src/gallium/drivers/freedreno/freedreno_query_hw.c +++ b/src/gallium/drivers/freedreno/freedreno_query_hw.c @@ -61,6 +61,8 @@ get_sample(struct fd_context *ctx, struct fd_ringbuffer *ring, struct fd_hw_sample *samp = NULL; int idx = pidx(query_type); + assume(idx >= 0); /* query never would have been created otherwise */ + if (!ctx->sample_cache[idx]) { ctx->sample_cache[idx] = ctx->sample_providers[idx]->get_sample(ctx, ring); _______________________________________________ mesa-commit mailing list mesa-commit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-commit