Module: Mesa Branch: master Commit: 544f41ff19426ad0fa07eed7e7cc3748aaa16dfa URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=544f41ff19426ad0fa07eed7e7cc3748aaa16dfa
Author: Brian Paul <bri...@vmware.com> Date: Fri Dec 15 14:36:25 2017 -0700 glsl: remove some continue statements In some cases, I think loop code is easier to read without continue statements. Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> --- src/compiler/glsl/link_varyings.cpp | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 5d398894d7..a1c2d424d4 100644 --- a/src/compiler/glsl/link_varyings.cpp +++ b/src/compiler/glsl/link_varyings.cpp @@ -1277,13 +1277,12 @@ parse_tfeedback_decls(struct gl_context *ctx, struct gl_shader_program *prog, * feedback of arrays would be useless otherwise. */ for (unsigned j = 0; j < i; ++j) { - if (!decls[j].is_varying()) - continue; - - if (tfeedback_decl::is_same(decls[i], decls[j])) { - linker_error(prog, "Transform feedback varying %s specified " - "more than once.", varying_names[i]); - return false; + if (decls[j].is_varying()) { + if (tfeedback_decl::is_same(decls[i], decls[j])) { + linker_error(prog, "Transform feedback varying %s specified " + "more than once.", varying_names[i]); + return false; + } } } } @@ -2571,12 +2570,11 @@ assign_varying_locations(struct gl_context *ctx, matches.store_locations(); for (unsigned i = 0; i < num_tfeedback_decls; ++i) { - if (!tfeedback_decls[i].is_varying()) - continue; - - if (!tfeedback_decls[i].assign_location(ctx, prog)) { - _mesa_hash_table_destroy(tfeedback_candidates, NULL); - return false; + if (tfeedback_decls[i].is_varying()) { + if (!tfeedback_decls[i].assign_location(ctx, prog)) { + _mesa_hash_table_destroy(tfeedback_candidates, NULL); + return false; + } } } _mesa_hash_table_destroy(tfeedback_candidates, NULL); _______________________________________________ mesa-commit mailing list mesa-commit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-commit