Module: Mesa
Branch: master
Commit: d9c525ed2240ff450f36a5d83c9c2c66087cd2bb
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=d9c525ed2240ff450f36a5d83c9c2c66087cd2bb

Author: Eric Anholt <e...@anholt.net>
Date:   Wed Apr  4 09:58:23 2018 -0700

broadcom/vc5: Drop the finished_seqno optimization.

With the DRM scheduler changes, I'm about to remove all seqnos from the
UABI.

---

 src/gallium/drivers/vc5/vc5_bufmgr.c | 4 ----
 src/gallium/drivers/vc5/vc5_screen.h | 7 -------
 2 files changed, 11 deletions(-)

diff --git a/src/gallium/drivers/vc5/vc5_bufmgr.c 
b/src/gallium/drivers/vc5/vc5_bufmgr.c
index 5e068400fd..bced512ae0 100644
--- a/src/gallium/drivers/vc5/vc5_bufmgr.c
+++ b/src/gallium/drivers/vc5/vc5_bufmgr.c
@@ -469,9 +469,6 @@ bool
 vc5_wait_seqno(struct vc5_screen *screen, uint64_t seqno, uint64_t timeout_ns,
                const char *reason)
 {
-        if (screen->finished_seqno >= seqno)
-                return true;
-
         if (unlikely(V3D_DEBUG & V3D_DEBUG_PERF) && timeout_ns && reason) {
                 if (vc5_wait_seqno_ioctl(screen->fd, seqno, 0) == -ETIME) {
                         fprintf(stderr, "Blocking on seqno %lld for %s\n",
@@ -489,7 +486,6 @@ vc5_wait_seqno(struct vc5_screen *screen, uint64_t seqno, 
uint64_t timeout_ns,
                 return false;
         }
 
-        screen->finished_seqno = seqno;
         return true;
 }
 
diff --git a/src/gallium/drivers/vc5/vc5_screen.h 
b/src/gallium/drivers/vc5/vc5_screen.h
index 710396de99..05a770ba2a 100644
--- a/src/gallium/drivers/vc5/vc5_screen.h
+++ b/src/gallium/drivers/vc5/vc5_screen.h
@@ -61,13 +61,6 @@ struct vc5_screen {
 
         const char *name;
 
-        /** The last seqno we've completed a wait for.
-         *
-         * This lets us slightly optimize our waits by skipping wait syscalls
-         * if we know the job's already done.
-         */
-        uint64_t finished_seqno;
-
         struct slab_parent_pool transfer_pool;
 
         struct vc5_bo_cache {

_______________________________________________
mesa-commit mailing list
mesa-commit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to