URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8a6e3f0c5daa196f39adbf842b356bfb00a8fd13 Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:59:06 2018 +0200
gallium/aux/util/u_cpu_detect.h: Fix -Wsign-compare warning in u_cpu_detect.c Change the type of util_cpu_caps::nr_cpus to int because sysconfig returns a signed value, fixes: u_cpu_detect.c: In function 'util_cpu_detect': u_cpu_detect.c:317:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (util_cpu_caps.nr_cpus == -1) Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=33f4e8a04396e3b2b3a8fd79e79fc6f268ee9653 Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:59:05 2018 +0200 gallium/aux/util/u_debug.h: Fix "noreturn" warnings in debug mode Only decorate function as noreturn when DEBUG is not defined, because when compiled in DEBUG mode the function actually executes an int3 and may return, fixes: u_debug.c: In function '_debug_assert_fail': u_debug.c:309:1: warning: 'noreturn' function does return Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=70f632962ac6d42f39ae762065caa049fc6352fd Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:59:04 2018 +0200 gallium/aux/util: Fix some warnings util/u_cpu_detect.c: In function 'util_cpu_detect': util/u_cpu_detect.c:377:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (util_cpu_caps.nr_cpus == ~0u) ^~ util/u_hash_table.c:274:21: warning: unused parameter 'k' [-Wunused- parameter] util_hash_inc(void *k, void *v, void *d) ^ util/u_hash_table.c:274:30: warning: unused parameter 'v' [-Wunused- parameter] util_hash_inc(void *k, void *v, void *d) ^ util/u_tests.c: In function 'test_texture_barrier': util/u_tests.c:652:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < num_samples / 2; i++) { ^ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3e091d5a7ad03897fab01be0f3af8a8c1b98a0e2 Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:59:03 2018 +0200 gallium/aux/tgsi_ureg.c: remove unused parameter from match_or_expand_immediate64 remove "type" from "match_or_expand_immediate64", fixes: tgsi/tgsi_ureg.c: In function 'match_or_expand_immediate64': tgsi/tgsi_ureg.c:837:34: warning: unused parameter 'type' [-Wunused- parameter] int type, ^~~~ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f79b9804862e61a93a60498d7360d991b332cb2c Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:59:02 2018 +0200 gallium/aux/tgsi_two_side.c: Fix -Wsign-compare warnings Integer propagation rules can sometimes be irritating. With "unsigned x" "x + 1" gets propagated to a signed integer, so explicitely assign the sum to an unsigned and use that for comaprison. In file included from tgsi/tgsi_two_side.c:41:0: tgsi/tgsi_two_side.c: In function 'xform_decl': ./util/u_math.h:660:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] #define MAX2( A, B ) ( (A)>(B) ? (A) : (B) ) ^ tgsi/tgsi_two_side.c:86:24: note: in expansion of macro 'MAX2' ts->num_inputs = MAX2(ts->num_inputs, decl->Range.Last + 1); ^~~~ ./util/u_math.h:660:40: warning: signed and unsigned type in conditional expression [-Wsign-compare] #define MAX2( A, B ) ( (A)>(B) ? (A) : (B) ) ^ tgsi/tgsi_two_side.c:86:24: note: in expansion of macro 'MAX2' ts->num_inputs = MAX2(ts->num_inputs, decl->Range.Last + 1); ^~~~ ./util/u_math.h:660:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] #define MAX2( A, B ) ( (A)>(B) ? (A) : (B) ) ^ tgsi/tgsi_two_side.c:89:23: note: in expansion of macro 'MAX2' ts->num_temps = MAX2(ts->num_temps, decl->Range.Last + 1); ^~~~ ./util/u_math.h:660:40: warning: signed and unsigned type in conditional expression [-Wsign-compare] #define MAX2( A, B ) ( (A)>(B) ? (A) : (B) ) ^ tgsi/tgsi_two_side.c:89:23: note: in expansion of macro 'MAX2' ts->num_temps = MAX2(ts->num_temps, decl->Range.Last + 1); ^~~~ tgsi/tgsi_two_side.c: In function 'xform_inst': tgsi/tgsi_two_side.c:184:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (inst->Src[i].Register.Index == ts- >front_color_input[j]) { ^~ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dc5ba7e17cf7395b3f3e444f03ef168a06cbdea8 Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:59:01 2018 +0200 gallium/aux/tgsi_ureg.c: Fix various warnings tgsi/tgsi_ureg.c: In function 'ureg_DECL_sampler': tgsi/tgsi_ureg.c:721:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (ureg->sampler[i].Index == nr) ^~ tgsi/tgsi_ureg.c: In function 'match_or_expand_immediate64': tgsi/tgsi_ureg.c:837:34: warning: unused parameter 'type' [-Wunused- parameter] int type, ^~~~ tgsi/tgsi_ureg.c: In function 'emit_decls': tgsi/tgsi_ureg.c:1821:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (ureg->properties[i] != ~0) ^~ tgsi/tgsi_ureg.c: In function 'ureg_create_with_screen': tgsi/tgsi_ureg.c:2193:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(ureg->properties); i++) ^ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c5e8280504cea3a07dfb07d05c542051c9844c49 Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:59:00 2018 +0200 gallium/aux/tgsi_text.c: Fix -Wsign-compare warnings tgsi/tgsi_text.c: In function 'parse_identifier': tgsi/tgsi_text.c:218:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (i == len - 1) ^~ tgsi/tgsi_text.c: In function 'parse_optional_swizzle': tgsi/tgsi_text.c:873:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < components; i++) { ^ tgsi/tgsi_text.c: In function 'parse_instruction': tgsi/tgsi_text.c:1103:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < info->num_dst + info->num_src + info->is_tex; i++) { ^ tgsi/tgsi_text.c:1118:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] else if (i < info->num_dst + info->num_src) { ^ tgsi/tgsi_text.c: In function 'parse_immediate': tgsi/tgsi_text.c:1660:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (type = 0; type < ARRAY_SIZE(tgsi_immediate_type_names); ++type) { ^ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b16b6d088914934032f59c53bb1eb31482ce6b47 Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:59 2018 +0200 gallium/aux/tgsi_point_sprite.c: Fix -Wsign-compare warnings tgsi/tgsi_lowering.c: In function 'emit_twoside': tgsi/tgsi_lowering.c:1179:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ctx->two_side_colors; i++) { ^ tgsi/tgsi_lowering.c:1208:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ctx->two_side_colors; i++) { ^ tgsi/tgsi_lowering.c:1216:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ctx->two_side_colors; i++) { ^ tgsi/tgsi_lowering.c: In function 'emit_decls': tgsi/tgsi_lowering.c:1280:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ctx->numtmp; i++) { ^ tgsi/tgsi_lowering.c: In function 'rename_color_inputs': tgsi/tgsi_lowering.c:1311:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (src->Index == ctx->two_side_idx[j]) { ^~ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3792d8575518c92233fdb924f4eefba0a95b7a33 Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:58 2018 +0200 gallium/aux/tgsi_lowering.c: Fix -Wsign-compare warnings tgsi/tgsi_lowering.c: In function 'emit_twoside': tgsi/tgsi_lowering.c:1179:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ctx->two_side_colors; i++) { ^ tgsi/tgsi_lowering.c:1208:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ctx->two_side_colors; i++) { ^ tgsi/tgsi_lowering.c:1216:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ctx->two_side_colors; i++) { ^ tgsi/tgsi_lowering.c: In function 'emit_decls': tgsi/tgsi_lowering.c:1280:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ctx->numtmp; i++) { ^ tgsi/tgsi_lowering.c: In function 'rename_color_inputs': tgsi/tgsi_lowering.c:1311:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (src->Index == ctx->two_side_idx[j]) { ^~ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7a3daaab413273f1a2bd5e74d6ff937ad0155ef0 Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:57 2018 +0200 gallium/aux/tgsi_build.c: Fix -Wsign-compare warnings tgsi/tgsi_build.c: In function 'tgsi_build_full_immediate': tgsi/tgsi_build.c:622:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for( i = 0; i < full_imm->Immediate.NrTokens - 1; i++ ) { ^ tgsi/tgsi_build.c: In function 'tgsi_build_full_property': tgsi/tgsi_build.c:1393:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for( i = 0; i < full_prop->Property.NrTokens - 1; i++ ) { ^ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=94f40d3ac06d481b66cc0f0cd21ef7bbfedd936d Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:56 2018 +0200 gallium/aux/tgsi_build.c: Remove now unused variable Removing the unused prev_tocken from the function calls made this local variable also unused. Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dc46b2aa990b85f47794a604141ec8239ffe868a Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:55 2018 +0200 gallium/aux/tgsi_build.c: Remove unused parameters prev_token from various functions remove parameter prev_token unused in tgsi_build_instruction_label tgsi_build_instruction_texture tgsi_build_instruction_memory tgsi_build_texture_offset This fixes the following warnings: tgsi/tgsi_build.c: In function 'tgsi_build_instruction_label': tgsi/tgsi_build.c:716:24: warning: unused parameter 'prev_token' [- Wunused-parameter] struct tgsi_token *prev_token, ^~~~~~~~~~ tgsi/tgsi_build.c: In function 'tgsi_build_instruction_texture': tgsi/tgsi_build.c:749:23: warning: unused parameter 'prev_token' [- Wunused-parameter] struct tgsi_token *prev_token, ^~~~~~~~~~ tgsi/tgsi_build.c: In function 'tgsi_build_instruction_memory': tgsi/tgsi_build.c:784:23: warning: unused parameter 'prev_token' [- Wunused-parameter] struct tgsi_token *prev_token, ^~~~~~~~~~ tgsi/tgsi_build.c: In function 'tgsi_build_texture_offset': tgsi/tgsi_build.c:819:23: warning: unused parameter 'prev_token' [- Wunused-parameter] struct tgsi_token *prev_token, ^~~~~~~~~~ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f06194b012c0c2b40d514cf6e31d7e60055e27af Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:54 2018 +0200 gallium/aux/tgsi_exec.c: Fix various -Wsign-compare tgsi/tgsi_exec.c: In function 'exec_tex': tgsi/tgsi_exec.c:2254:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] assert(shadow_ref >= dim && shadow_ref < ARRAY_SIZE(args)); ^ ./util/u_debug.h:189:30: note: in definition of macro 'debug_assert' #define debug_assert(expr) ((expr) ? (void)0 : _debug_assert_fail(#expr, __FILE__, __LINE__, __FUNCTION__)) ^~~~ tgsi/tgsi_exec.c:2254:7: note: in expansion of macro 'assert' assert(shadow_ref >= dim && shadow_ref < ARRAY_SIZE(args)); ^~~~~~ tgsi/tgsi_exec.c:2290:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = dim; i < ARRAY_SIZE(args); i++) ^ In file included from ./util/u_memory.h:39:0, from tgsi/tgsi_exec.c:62: tgsi/tgsi_exec.c: In function 'exec_lodq': tgsi/tgsi_exec.c:2357:15: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] assert(dim <= ARRAY_SIZE(coords)); ^ ./util/u_debug.h:189:30: note: in definition of macro 'debug_assert' #define debug_assert(expr) ((expr) ? (void)0 : _debug_assert_fail(#expr, __FILE__, __LINE__, __FUNCTION__)) ^~~~ tgsi/tgsi_exec.c:2357:4: note: in expansion of macro 'assert' assert(dim <= ARRAY_SIZE(coords)); ^~~~~~ tgsi/tgsi_exec.c:2363:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = dim; i < ARRAY_SIZE(coords); i++) { ^ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a7cbb9ba4677401e52e52df3e4fc3a71123751de Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:53 2018 +0200 gallium/aux/tgsi_exec.c: remove superfluous parameter from etch_source_d Remove unused parameter src_datatype from fetch_source_d, fixes warning; tgsi/tgsi_exec.c: In function 'fetch_source_d': tgsi/tgsi_exec.c:1594:40: warning: unused parameter 'src_datatype' [-Wunused-parameter] enum tgsi_exec_datatype src_datatype) ^~~~~~~~~~~~ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5fe1b3b848fdef1116704d38ac777a76a5f247b1 Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:52 2018 +0200 gallium/aux/tgsi_exec.c: remove superfluous parameter from store_dest_dstret remove unused parameter inst from store_dest_dstret (and consequently also from store_dest_double), fixes warning: tgsi/tgsi_exec.c: In Funktion »store_dest_dstret«: tgsi/tgsi_exec.c:1765:47: Warning: unused parameter »inst« [-Wunused-parameter] const struct tgsi_full_instruction *inst) ^~~~ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c9b53c641006e2c0c869942284cf1dc84f9deca4 Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:51 2018 +0200 gallium/aux/tgsi_exec.c: Remove unused parameter from fetch_src_file_channel remove unused parameter chan_index from fetch_src_file_channel, fixes warning: tgsi/tgsi_exec.c: In Funktion »fetch_src_file_channel«: tgsi/tgsi_exec.c:1480:35: Warning: unused parameter »chan_index« [-Wunused-parameter] const uint chan_index, ^~~~~~~~~~ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=38a9b42d8e2f86ce0ea4e34a1f5371358b00f93d Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:50 2018 +0200 gallium/aux/tgsi_exec.c: Remove paramater inst from exec_kill Fixes warning: tgsi/tgsi_exec.c: In Funktion »exec_kill«: tgsi/tgsi_exec.c:2049:47: Warning: unused parameter »inst« [-Wunused-parameter] const struct tgsi_full_instruction *inst) ^~~~ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b8fca73e472b05448f4b826785fecd126d4ab904 Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:49 2018 +0200 gallium/aux/tgsi_aa_point.c: Fix -Wsign-compare warnings tgsi/tgsi_aa_point.c:32:0: tgsi/tgsi_aa_point.c: In Funktion »aa_decl«: ./util/u_math.h:660:29: Comparison between signed and unsigned in conditional expressions [-Wsign-compare] #define MAX2( A, B ) ( (A)>(B) ? (A) : (B) ) ^ tgsi/tgsi_aa_point.c:76:21: Remark: when substituting of the macro »MAX2« ts->num_tmp = MAX2(ts->num_tmp, decl->Range.Last + 1); ^~~~ ./util/u_math.h:660:40: Warning: signed and unsigned type in conditional expression [-Wsign-compare] #define MAX2( A, B ) ( (A)>(B) ? (A) : (B) ) ^ tgsi/tgsi_aa_point.c:76:21: Remark: when substituting of the macro »MAX2« ts->num_tmp = MAX2(ts->num_tmp, decl->Range.Last + 1); ^~~~ tgsi/tgsi_aa_point.c: In Funktion »aa_inst«: tgsi/tgsi_aa_point.c:220:31: Comparison between signed and unsigned in conditional expressions [-Wsign-compare] dst->Register.Index == ts->color_out) { Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=09b3b37b95d492df959f3615641661fcfb6a93ec Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:48 2018 +0200 gallium/aux/tgsi_sanity.c: Fix -Wsign-compare warnings tgsi_sanity.c: In function 'iter_instruction': tgsi_sanity.c:316:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (ctx->index_of_END != ~0) { ^~ tgsi_sanity.c: In function 'epilog': tgsi_sanity.c:488:26: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (ctx->index_of_END == ~0) { Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bf6b695a90d7f1ee6b1af93301ed91c4fdd8d9af Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:47 2018 +0200 gallium/aux/tgsi/tgsi_parse.c: Fix two warnings tgsi_parse.c: In function 'tgsi_parse_free': tgsi_parse.c:54:31: warning: unused parameter 'ctx' [-Wunused-parameter] struct tgsi_parse_context *ctx ) ^~~ tgsi_parse.c: In function 'tgsi_parse_end_of_tokens': tgsi_parse.c:62:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] return ctx->Position >= Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fc9e259e58ef73633bd51827427cc2ea63569ae0 Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:46 2018 +0200 gallium/aux/tgsi/tgsi_dump.c: Fix -Wsign-compare warnings tgsi_dump.c: In function 'iter_property': tgsi_dump.c:443:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < prop->Property.NrTokens - 1; ++i) { ^ tgsi_dump.c:459:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (i < prop->Property.NrTokens - 2) Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Marek Olšák <marek.ol...@amd.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=03ac9708cf64832a19d6dca95c8fd1fdfc4d70ab Author: Gert Wollny <gert.wol...@collabora.com> Date: Tue Jun 5 13:58:45 2018 +0200 gallium/aux/cso_cache: Fix various warnings cso_cache.c: In Function »delete_blend_state«: cso_cache/cso_cache.c:90:51: Warning: unused parameter »data« [-Wunused- parameter] static void delete_blend_state(void *state, void *data) ^~~~ cso_cache/cso_cache.c: In Funktion »delete_depth_stencil_state«: cso_cache/cso_cache.c:98:59: Warning: unused parameter »data« [-Wunused- parameter] static void delete_depth_stencil_state(void *state, void *data) ^~~~ cso_cache/cso_cache.c: In Funktion »delete_sampler_state«: cso_cache/cso_cache.c:106:53: Warning: unused parameter »data« [- Wunused-parameter] static void delete_sampler_state(void *state, void *data) ^~~~ cso_cache/cso_cache.c: In Funktion »delete_rasterizer_state«: cso_cache/cso_cache.c:114:56: Warning: unused parameter »data« [- Wunused-parameter] static void delete_rasterizer_state(void *state, void *data) ^~~~ cso_cache/cso_cache.c: In Funktion »delete_velements«: cso_cache/cso_cache.c:122:49: Warning: unused parameter »data« [- Wunused-parameter] static void delete_velements(void *state, void *data) ^~~~ cso_cache/cso_cache.c: In Funktion »sanitize_cb«: cso_cache/cso_cache.c:166:52: Warning: unused parameter »user_data« [- Wunused-parameter] int max_size, void *user_data) ^~~~~~~~~ gallium/aux/cso_context.c: a -Wunused-parameter warning cso_cache/cso_context.c: In Funktion »delete_sampler_state«: cso_cache/cso_context.c:163:57: Warning: unused parameter »ctx« [- Wunused-parameter] static boolean delete_sampler_state(struct cso_context *ctx, void *state) ^~~ Signed-off-by: Gert Wollny <gert.wol...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=81e5bf3cfef60edb093cde35bace061a8543dba5 Author: Gert Wollny <gert.wol...@collabora.com> Date: Mon Jun 11 18:24:39 2018 +0200 configure.ac: Add CFLAG -Wno-missing-field-initializers (v5) This warning is misleading: When a struct is partially initialized without assigning to the structure members by name, then the remaining fields will be zeroed out, and this warning will be issued (if enabled). If, on the other hand, the partial initialization is done by assigning to named members, the remaining structure elements may hold random data, but the warning is not issued. Since in Mesa the first approach to initialize structure elements is used very often, and it is usually assumed that the remaining elements are zeroed out, heeding this warning would be counter-productive. v2: - add -Wno-missing-field-initializers to meson-build - fix empty line error (both Eric Engestrom) v3: * check for -Wmissing-field-initializers warning and then disable it because gcc and clang always accept -Wno-* (Dylan Baker) * Also disable this warning for C++ v4: * meson.build add -Wno-missing-field-initializers to c_args instead of no_override_init_args (Eric Engstrom) v5: * configure.ac: Correct copy/paste error with CFLAGS/CXXFLAGS Reviewed-by: Marek Olšák <marek.ol...@amd.com> (v1) Reviewed-by: Emil Velikov <emil.veli...@collabora.com> (v2) Reviewed-by: Eric Engestrom <eric.engest...@intel.com> Signed-off-by: Gert Wollny <gert.wol...@collabora.com> _______________________________________________ mesa-commit mailing list mesa-commit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-commit