Module: Mesa Branch: master Commit: b9f7f3e4972bd758e903adbdb6bdc2152413de73 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b9f7f3e4972bd758e903adbdb6bdc2152413de73
Author: Eric Anholt <[email protected]> Date: Wed Jun 19 12:00:57 2019 -0700 freedreno: Drop stale comment about skipping uploads. We already skip the upload if it's unused, due to the constlen > offset check. Reviewed-by: Rob Clark <[email protected]> --- src/gallium/drivers/freedreno/ir3/ir3_gallium.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_gallium.c b/src/gallium/drivers/freedreno/ir3/ir3_gallium.c index fde02aa23c9..ad74c8b1b66 100644 --- a/src/gallium/drivers/freedreno/ir3/ir3_gallium.c +++ b/src/gallium/drivers/freedreno/ir3/ir3_gallium.c @@ -496,7 +496,6 @@ ir3_emit_vs_consts(const struct ir3_shader_variant *v, struct fd_ringbuffer *rin emit_common_consts(v, ring, ctx, PIPE_SHADER_VERTEX); /* emit driver params every time: */ - /* TODO skip emit if shader doesn't use driver params to avoid WFI.. */ if (info) { const struct ir3_const_state *const_state = &v->shader->const_state; uint32_t offset = const_state->offsets.driver_param; _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
