Module: Mesa Branch: staging/20.0 Commit: 17c33450a1aa77689cf09ebafe8e8df5e6e537f4 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=17c33450a1aa77689cf09ebafe8e8df5e6e537f4
Author: Jason Ekstrand <[email protected]> Date: Mon Mar 16 22:58:53 2020 -0500 anv: Do an end-of-pipe sync before updating AUX table entries We've found in GL that an actual end-of-pipe sync is required before invalidating the aux tables and that a simple CS stall is insufficient. If we're about to modify the actual AUX table entries from the GPU, we should definitely make sure it's stopped dead before we do so. Cc: [email protected] Reviewed-by: Rafael Antognolli <[email protected]> Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4206> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4206> (cherry picked from commit d60375cbc2510ab7ad90b2654c0f6324468415cf) --- .pick_status.json | 2 +- src/intel/vulkan/genX_cmd_buffer.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 5e57eb6af31..e5c6f8f6ca0 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -184,7 +184,7 @@ "description": "anv: Do an end-of-pipe sync before updating AUX table entries", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "master_sha": null, "because_sha": null }, diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index e109c57ac00..4ad65688a67 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@ -1021,7 +1021,7 @@ anv_image_init_aux_tt(struct anv_cmd_buffer *cmd_buffer, * with not having this stall in some cases if we were really careful but * it's better to play it safe. Full stall the GPU. */ - cmd_buffer->state.pending_pipe_bits |= ANV_PIPE_CS_STALL_BIT; + cmd_buffer->state.pending_pipe_bits |= ANV_PIPE_END_OF_PIPE_SYNC_BIT; genX(cmd_buffer_apply_pipe_flushes)(cmd_buffer); struct gen_mi_builder b; _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
