On Thu, 5 May 2011 10:07:24 -0700 Jeremy Huddleston <jerem...@freedesktop.org> wrote:
> Why is sbc a 32bit field in xGLXBufferSwapComplete2 and > xDRI2BufferSwapComplete2 when it is a 64bit field in GLXBufferSwapComplete? > > The hunk at the bottom will result in casting a 64bit int to a 32bit int. If > you're going to change this, shouldn't you also change GLXBufferSwapComplete, > DRI2SwapEvent() and everything else that has a 64bit swap count? > > Isn't it easier to correct the spec to match reality? No because XEvents are only 32 bytes. We actually noticed that when publishing the spec, but we never updated the code. And yes, I should change the CARD64s to CARD32s as in the previous patch. Accidentally dropped that part when reverting. Thanks, Jesse _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
