This is a re-send of the unit tests for lower_jumps.cpp which I sent to the mailing list on July 8. I haven't received any comments yet, and since this is a rewrite of some patches that proved controversial, I'd appreciate some comments as to whether the issues from my previous submission have been adequately addressed.
The concerns from the previous patch series (which was sent to the list on July 5) were, as I understood them, mainly about the maintainability and readability of the tests in the form the were in (a Python script which used a lot of auxiliary functions to build up the IR test vectors on the fly). To address these concerns, I've changed the tests into simple bash scripts. The input IR, and the expected output, are now visible in the source files in their standard S-expression form. I believe the patches as they stand now address all the concerns that were brought up. If I don't hear anything by Friday July 22, I'll assume that there aren't any concerns remaining and go ahead and push the patches. Thanks, Paul [PATCH 1/4] mesa: Add an ifndef guard around the definition of the INLINE macro [PATCH 2/4] glsl: Move initialize_context() to glsl_parser_extras.cpp so it can be re-used. [PATCH 3/4] glsl: Create a standalone executable for testing optimization passes. [PATCH 4/4] glsl: Add unit tests for lower_jumps.cpp _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
