Ben Widawsky <b...@bwidawsk.net> writes: > I really don't know the corner cases well enough, but concept seems > good to me. In particular, I assume this is now going to return false > for more cases than previously - and that's okay, I guess?
In practice I don't think it will disable any extra formats because the intel_get_memcpy function which this calls is a lot more strict about which specific formats it takes anyway. It's a bit weird because intel_get_memcpy explicitly allows BGRX and RGBX so Jason's original patch could have been implemented by just removing that explicit support. However now that the condition is being changed to look at _BaseFormat instead I think it does make more sense to leave the check in intel_gettexsubimage_tiled_memcpy. Regards, - Neil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
