On 2015-11-25 00:12:15, Iago Toral wrote: > On Tue, 2015-11-17 at 21:54 -0800, Jordan Justen wrote: > > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > > --- > > src/glsl/lower_variable_index_to_cond_assign.cpp | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/src/glsl/lower_variable_index_to_cond_assign.cpp > > b/src/glsl/lower_variable_index_to_cond_assign.cpp > > index 1ab3afe..a1ba934 100644 > > --- a/src/glsl/lower_variable_index_to_cond_assign.cpp > > +++ b/src/glsl/lower_variable_index_to_cond_assign.cpp > > @@ -378,6 +378,9 @@ public: > > case ir_var_shader_storage: > > return this->lower_uniforms; > > > > + case ir_var_shader_shared: > > + return false; > > I suppose the right thing to do here is to add a lower_shared_variables > parameter to this and take its value from a compiler option that we set > to false, like we do with the other types, but I guess this is good > enough for now:
Yeah, I mostly implemented that twice, but both times I ended up thinking, maybe we should wait to see what different drivers actually end up needing for shared variables. I think we made a similar choise with SSBO. Right now, SSBOs follow the EmitNoIndirectUniform setting, but it might be possible that a driver needs to handle UBOs and SSBOs differently. -Jordan > Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> > > > case ir_var_function_in: > > case ir_var_const_in: > > return this->lower_temps; > > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev