Grazvydas Ignotas <nota...@gmail.com> writes:
> On Sun, Apr 17, 2016 at 2:50 AM, Emil Velikov <emil.l.veli...@gmail.com>
> wrote:
>> On 16 April 2016 at 02:00, Grazvydas Ignotas <nota...@gmail.com> wrote:
>>> This is mostly for variables that are only used in asserts and cause
>>> unused-but-set-variable warnings in release builds. Could just use
>>> UNUSED directly, but MAYBE_UNUSED should be less confusing and is
>>> similar to what the Linux kernel has.
>>>
>>> And yes __attribute__((unused)) can be used on variables on both GCC 4.2
>>> (oldest supported by mesa) and clang 3.0 (just some random old version,
>>> nut sure what's the minimum for mesa).
>>>
>>> Signed-off-by: Grazvydas Ignotas <nota...@gmail.com>
>>> ---
>>> I have no commit access, if this patch is ok, please someone push.
>>>
>>> src/util/macros.h | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/src/util/macros.h b/src/util/macros.h
>>> index 0c8958f..f081bb8 100644
>>> --- a/src/util/macros.h
>>> +++ b/src/util/macros.h
>>> @@ -204,6 +204,8 @@ do { \
>>> #define UNUSED
>>> #endif
>>>
>>> +#define MAYBE_UNUSED UNUSED
>>> +
>> Hell yeah !
>>
>> A thing that comes to mind ... a while back we've been wondering about
>> (re)naming these just the the way we do in the kernel. Namely
>> __maybe_unused in this case. Can you give that one a try and link a
>> branch.
>
> I hope you mean something like this?
> https://github.com/notaz/mesa/commits/warnings
>You guys know that in standard C any identifier (including a preprocessor define) starting with double underscore is reserved for the implementation and causes the program's behavior to be undefined? The kernel is kind of part of the implementation so they can do whatever they want, but it seems dubious to do the same in a userspace library. How about you use a single (or no) underscore if people prefer the lowercase spelling? > GraÅžvydas > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
