On 06.05.2016 19:09, Marek Olšák wrote: > On Fri, May 6, 2016 at 12:01 PM, Michel Dänzer <mic...@daenzer.net> wrote: >> On 06.05.2016 02:01, Marek Olšák wrote: >>>> There is one more hardware limitation that can cause VM faults with T2L >>>> copies and needs a workaround. The exact workaround is still under >>>> discussion, but I think this is good enough for review already. >>> >>> BTW, the T2L VM fault is completely harmless. It's caused by SDMA >>> reading more entries from the page directory than needed. The >>> workaround can be added in a follow-up patch. >> >> So you're proposing pushing these patches in a form which results in >> dmesg being flooded by GPUVM faults? If so, not sure that's a good idea, >> it'll probably result in bug reports. > > Unlikely, I haven't been able to reproduce it even with piglit and > that crazy DMA test. It came from a discussion with hw guys that such > a bug exists.
I see, I thought this was still about the VM faults myself and Alex were seeing when playing with using the old SDMA code replaced by this series in more cases. > I can squash the fix with the right patch before pushing. The series can land without the workaround then as far as I'm concerned, once Nicolai or somebody else has reviewed it in detail. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
