I left a minor comment in patch 4, but other than that patches 1-4 are: Reviewed-by: Iago Toral Quiroga <ito...@igalia.com>
On Thu, 2016-05-19 at 00:20 -0700, Jason Ekstrand wrote: > Right now, we're just setting the range to [0, MAX_UINT32] which, while > correct isn't helpful. With DrawIndirect, you can't really know what the > actual range is so we may as well flag it as being an invalid range. This > is what we do for draws with index buffer which is similar (the indices > aren't statically known) if a bit simpler. > > Cc: "10.2" <mesa-sta...@lists.freedesktop.org> > --- > src/mesa/vbo/vbo_context.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c > index 9f807a1..ae5d265 100644 > --- a/src/mesa/vbo/vbo_context.c > +++ b/src/mesa/vbo/vbo_context.c > @@ -170,7 +170,7 @@ vbo_draw_indirect_prims(struct gl_context *ctx, > } > > vbo->draw_prims(ctx, prim, draw_count, > - ib, GL_TRUE, 0, ~0, > + ib, false, ~0, ~0, > NULL, 0, > ctx->DrawIndirectBuffer); > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
