On Tuesday 17 May 2016 22:54:01 Giuseppe Bilotta wrote: > On Sun, May 15, 2016 at 10:54 PM, Giuseppe Bilotta > > <giuseppe.bilo...@gmail.com> wrote: > > On Sun, May 15, 2016 at 9:35 AM, Vedran Miletić <riva...@gmail.com> wrote: > >> How about also adding Mesa git version, like "OpenGL core profile > >> version string" has now? > > > > That's probably a good idea. Conversely, would it be sensible to add > > the LLVM version string to the OpenGL version string too? Maybe the > > entire suffix vendor string could be unified across GL and CL? > > Ok, unification of the version string would actually cause a small > issue due to the fact that in OpenGL we use the spelling "Mesa", > whereas in clover for some reason we use "MESA". It should be > relatively safe to change the OpenCL spelling to match the OpenGL > spelling (I'm not aware of any software that explicitly does things > differently on detecting Clover checking for the version string) or > just keep it separate?
Mesa or MESA spelling shouldn't be an issue. And that would be coherent with CL_PLATFORM_VENDOR that is returning "Mesa" > > Second question: shall I squash the introduction of the SHA1 in Clover > with the introduction of the LLVM version everywhere, or should I keep > those as separate patches? I have no opinion on that. - Serge _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
