On Tue, 2016-06-14 at 22:44 +0200, Jakob Sinclair wrote: > On 2016-06-14 20:39, Jan Vesely wrote: > > I really disagree here. The conditions check whether swizzle is > > between > > X and W (as in, only X,Y,Z,W are allowed). The fact that X maps to > > 0 is > > irrelevant. removing the checks impairs readability of the code > > because > > the lower bound is now inferred (by being 0) rather than explicit. > > > > the same comment applies to your v2. > > > > Jan > > Thanks for the input. Now when I think about it again this is > probably a > bad change. > Didn't think about the lower bound. So this patch should probably not > be > pushed.
It'd still be nice to have them fixed.
those lines produce Wtype-limits ("comparison always false due to
limited range of data types") warnings which are rather useful in other
cases, since type-limits can lead to DCE of useful code with aggressive
optimization.
not sure what the best way to do is, though.
Jan
--
Jan Vesely <jan.ves...@rutgers.edu>
signature.asc
Description: This is a digitally signed message part
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
