Tomasz Figa <tf...@chromium.org> writes: > Hi Eric, > > On Sat, Jul 16, 2016 at 3:05 AM, Eric Anholt <e...@anholt.net> wrote: >> Tomasz Figa <tf...@chromium.org> writes: >> >>> Current implementation of the DRI image loader does not free the images >>> created in get_back_bo() and so leaks memory. Moreover, it creates a new >>> image every time the DRI driver queries for buffers, even if the backing >>> native buffer has not changed. leaking memory again. >>> >>> This patch adds missing call to destroyImage() in droid_enqueue_buffer() >>> and a check if image is already created to get_back_bo() to fix the >>> above. >> >> This patch is: >> >> Reviewed-by: Eric Anholt <e...@anholt.net> >> >> But I noticed in review, it looks like droid_destroy_surface() could >> also use an image destroy. > > Thanks for review! > > It already calls droid_window_cancel_buffer(), which in turns calls > droid_window_enqueue_buffer() (typo in commit message...). Or you mean > something else I didn't notice?
Ah, I missed that path. Excellent.
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
