On Sun, Sep 25, 2011 at 4:22 PM, Gaetan Nadon <mems...@videotron.ca> wrote: > If you are moving towards a non-hacked automake world, the INSTALL variable > should not be used for mesa makefiles. It all depends on the end goals and > the motivation behind the conversion to automake which has not been > explained yet.
Personally, being able to do out-of-tree builds is a big improvement by switching to automake. Dan lists a number of other benefits in his first email here: http://lists.freedesktop.org/archives/mesa-dev/2010-May/000431.html >> There is a 'configuration' file. How will the automake makefiles take that >> into account. > > I would think the configs/autoconf file is something we'd kill off > after the last static Makefile is gone. > >> It looks like there are 'conflicts' between mesa makefiles and automake >> which is expected due to the size of the project. Some preparation work >> should be done upfront to make both system coexist and then have automake >> gradually replace mesa makefiles. This would be useful work anyway. > > There's definitely some clean ups to be done, that's for sure. > > Regarding Makefile.am: Use $(VAR) rather than @VAR@ Automake has an > explanation for that. > > You will need AC_CONFIG_HEADERS, there will too many -D on the command line. > > -I../../include can be $(top_srcdir/include) Easy to read, easy to copy > even across makefiles at any depth Good, I'll make those two changes. Similarly, we have a lot of -D flags like -DFEATURE_GL=1. I suppose they are best left in CPPFLAGS? Thanks, Matt _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev