On 09/08/16 05:59 AM, ⚛ wrote: > On Mon, Aug 8, 2016 at 7:14 PM, Ian Romanick <i...@freedesktop.org> wrote: >> On 08/08/2016 09:38 AM, ⚛ wrote: >>> On Mon, Aug 8, 2016 at 6:22 PM, Ian Romanick <i...@freedesktop.org> wrote: >>>> I'm pretty sure this breaks ABI. Did you try using an unpatched libGL >>>> with a patched *_dri.so (and vice-versa)? >>> >>> Can you be more specific? >> >> Eh... build Mesa. Save the libGL and *_dri.so. Apply patch. Build >> again. Run applications with LD_PRELOAD and LIBGL_DRIVERS_PATH (or >> EGL_DRIVERS_PATH) set to mix the old and new. > > - The changes to the data structures in the patch do not necessarily > imply that mixing-unpatched-patched libs will fail because the > alignment of fields might stay the same.
Unless sizeof(bool) == sizeof(int), it would still break ABI at least on big endian platforms. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
