On Mon, Aug 8, 2016 at 5:09 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > Does this fix any tests? If so, we should say so in the commit message. > With that updated, > No it doesn't. It surprised me too but it looks like cts don't have enough multisampling tests.
> Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net> > > On Mon, Aug 8, 2016 at 2:57 PM, Anuj Phogat <anuj.pho...@gmail.com> wrote: >> >> Signed-off-by: Anuj Phogat <anuj.pho...@gmail.com> >> --- >> src/intel/vulkan/gen7_pipeline.c | 16 +--------------- >> 1 file changed, 1 insertion(+), 15 deletions(-) >> >> diff --git a/src/intel/vulkan/gen7_pipeline.c >> b/src/intel/vulkan/gen7_pipeline.c >> index 5395e79..17d7ccc 100644 >> --- a/src/intel/vulkan/gen7_pipeline.c >> +++ b/src/intel/vulkan/gen7_pipeline.c >> @@ -81,21 +81,7 @@ genX(graphics_pipeline_create)( >> pCreateInfo->pRasterizationState, extra); >> emit_3dstate_streamout(pipeline, pCreateInfo->pRasterizationState); >> >> - if (pCreateInfo->pMultisampleState && >> - pCreateInfo->pMultisampleState->rasterizationSamples > 1) >> - >> anv_finishme("VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO"); >> - >> - uint32_t samples = 1; >> - uint32_t log2_samples = __builtin_ffs(samples) - 1; >> - >> - anv_batch_emit(&pipeline->batch, GENX(3DSTATE_MULTISAMPLE), ms) { >> - ms.PixelLocation = PIXLOC_CENTER; >> - ms.NumberofMultisamples = log2_samples; >> - } >> - >> - anv_batch_emit(&pipeline->batch, GENX(3DSTATE_SAMPLE_MASK), sm) { >> - sm.SampleMask = 0xff; >> - } >> + emit_ms_state(pipeline, pCreateInfo->pMultisampleState); >> >> const struct brw_vs_prog_data *vs_prog_data = >> get_vs_prog_data(pipeline); >> >> -- >> 2.5.5 >> >> _______________________________________________ >> mesa-dev mailing list >> mesa-dev@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev