On Wed, Aug 31, 2016 at 05:41:24PM -0700, Jason Ekstrand wrote: > On Wed, Aug 31, 2016 at 8:17 AM, Topi Pohjolainen > <[1][email protected]> wrote: > > Otherwise once mcs buffer gets allocated without delay for > lossless compression (same as we do for msaa), assert starts > to fire in piglit case: tex3d. The test uses depth of one > which is in fact supported even now. > Signed-off-by: Topi Pohjolainen <[2][email protected]> > --- > Ã src/intel/isl/isl.c | 7 ++++++- > Ã 1 file changed, 6 insertions(+), 1 deletion(-) > diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > index c4989dd..b5c4a8c 100644 > --- a/src/intel/isl/isl.c > +++ b/src/intel/isl/isl.c > @@ -1328,7 +1328,12 @@ isl_surf_get_ccs_surf(const struct isl_device > *dev, > Ã Ã assert(surf->samples == 1 && surf->msaa_layout == > ISL_MSAA_LAYOUT_NONE); > Ã Ã assert(ISL_DEV_GEN(dev) >= 7); > -Ã Ã assert(surf->dim == ISL_SURF_DIM_2D); > +Ã Ã if (ISL_DEV_GEN(dev) < 8) { > +Ã Ã Ã assert(surf->dim == ISL_SURF_DIM_2D); > +Ã Ã } else { > +Ã Ã Ã assert(surf->dim == ISL_SURF_DIM_2D || surf->dim == > ISL_SURF_DIM_3D); > +Ã Ã } > > What about 1D?Ã Maybe we just never try to allocate 1D Y-tiled.Ã
I guess so, I can't think of any restrictions why compression or fast clear itself wouldn't be supported. > Also, if it's 3D, should we assert depth == 1? Check for the depth is just below. > Ã > > + > Ã Ã assert(surf->logical_level0_px.depth == 1); > Ã Ã /* TODO: More conditions where it can fail. */ > -- > 2.5.5 > _______________________________________________ > mesa-dev mailing list > [3][email protected] > [4]https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > References > > 1. mailto:[email protected] > 2. mailto:[email protected] > 3. mailto:[email protected] > 4. https://lists.freedesktop.org/mailman/listinfo/mesa-dev > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
