On Thu 08 Sep 2016, Emil Velikov wrote:
> On 8 September 2016 at 04:29, Chad Versace <chadvers...@chromium.org> wrote:
> > The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so.
> > But it's needed only if HAVE_PLATFORM_X11.
> >
> > Fixes build of libvulkan_intel.so on Chromium OS, which has no X11
> > libraries.
> >
> Pretty sure that was the "must fix" part of my review comment ;-)
> 
> > Cc: Kevin Strasser <kevin.stras...@intel.com>
> > Cc: Jason Ekstrand <ja...@jlekstrand.net>
> > Change-Id: Ib42db7db582c4531cf13db65f2ad5d57db1d774d

> Please drop this ?

Dropped.

> 
> Fixes: 71258e9462c ("anv/x11: Add support for Xlib platform")
> Reviewed-by: Emil Velikov <emil.veli...@collabora.com>

Footers added.

And pushed.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to