-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/10/2011 10:53 AM, Eric Anholt wrote: > On Fri, 7 Oct 2011 10:16:47 -0700, Chad Versace <[email protected]> wrote: >> The "slight optimization to avoid the GS program" in brw_set_prim() is not >> used by Gen 6, since Gen 6 doesn't use a GS program. Also, Gen 6 doesn't use >> reduced primitives. >> >> Also, document that intel_context.reduced_primitive is only used for Gen < 6 >> >> Signed-off-by: Chad Versace <[email protected]> > >> diff --git a/src/mesa/drivers/dri/intel/intel_context.h >> b/src/mesa/drivers/dri/intel/intel_context.h >> index eb78c00..cf7ab9e 100644 >> --- a/src/mesa/drivers/dri/intel/intel_context.h >> +++ b/src/mesa/drivers/dri/intel/intel_context.h >> @@ -253,7 +253,7 @@ struct intel_context >> GLuint RenderIndex; >> GLmatrix ViewportMatrix; >> GLenum render_primitive; >> - GLenum reduced_primitive; >> + GLenum reduced_primitive; /*< Only gen < 6 */ > > If this is intended to be doxygen, that would be /**< whatever */ > > Other than that, Reviewed-by: Eric Anholt <[email protected]>
Thanks for catching that. I'll doxygenate it before pushing. - -- Chad Versace [email protected] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOkz4qAAoJEAIvNt057x8iWp0P/RS97RabqRhJ7KX52hor+/w3 D4jYyBZU59Giyg3MdLkwLyCgFilyyelo83R55tKQfHU87nS2aTGTQflIEyq0L/bZ DRJklSz/pOEU4k49WNYcomkbMruLAbt+3ps/1RqK/tx/d4Jj9JIc9dEAXNMIBAjp SP/sf6+dEplzu4EPfAdA3cJN8ysiXox0NAd0wt1oTdxZNwxn8zn89DW5dtF8uD47 yzh4xA+PjoNZ9p9eHW+asHdsbEDog1eSHZ3dqztm1yNeBKpLjwR0J3U7s9miUXVl QtXd/mad6vDHFfITMpu7GaBx+TQC8Evx3Nc+gCeClWWcKGQgkM4frurKL4PtxyWJ y9JnN81vmo29j5SpK1DeWgC+sm8rbrY48+XOiiknb6dz8JxICZYwrD396v7bM+Z5 TF3muyTrngGV3WA4RU1jLrtQjI9T847hGyKD/C2dLke92VZ5onK2gmRZ05UDAtB+ 5fq3WbwlN5h1jS99FjggWfObGUWiqpLgHk5jxevLFPx8sbZHBVLNHv/raiJ3RETe aWiVefwV73HLIdxjRVOQv5EzTqPqLN2pOIG3KDdjmSudMaUA3bPzeGcDaI/8QTYe WrIJ5Mi6cN6UwcyPsWEsy8Z/EPTlczQSJNRDkTXUNktG1UsbsV3qFEUwZprc7aTh C3JlF/bVrQSlHt8I7wob =WiPo -----END PGP SIGNATURE----- _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
