From: Landwerlin, Lionel G
Sent: Wednesday, October 05, 2016 9:55 AM
To: Jason Ekstrand <ja...@jlekstrand.net>
Cc: mesa-dev@lists.freedesktop.org; Gandikota, Sirisha
<sirisha.gandik...@intel.com>
Subject: Re: [Mesa-dev] [PATCH v3 3/5] intel: aubinator: generate a standalone
binary
On 05/10/16 17:07, Jason Ekstrand wrote:
+$(builddir)/%_aubinator_xml.h: $(srcdir)/../genxml/%.xml Makefile
+ $(MKDIR_GEN)
+ $(AM_V_GEN) echo -n "static const uint8_t " > $@; \
+ echo -n `basename $@` | sed -e 's,_aubinator_xml.h,,' >> $@; \
+ echo "_xml[] = {" >> $@; \
+ cat $< | $(XXD) -i >> $@; \
+ echo "};" >> $@
I talked to Sirisha a bit yesterday and she wasn't terribly happy with the way
this "dirtied" things. I *think* what she didn't like was the piles of
autogenerated files it dumps in the tools directory. Sirisha, please correct
me if I'm misunderstanding you.
One option would be to generate them in the genxml directory as genN_xml.h. We
already have genN_pack.h, so it's no big deal to dump more there. Another
option would be to add a genxml_include directory to tools/ and dump them there
to get them out of the way.
Personally, I don't think it's a big deal, but I'm also ok with trying to keep
things clean.
Ok, I'll move that to genxml/ if Sirisha is alright with that.
[SG] genxml/ seems to be the most logical place for the files. Yeah, I
downloaded the patches and tried to work with the code, and those generated
files were distracting to me. While the idea behind doing that is good, I just
prefer a cleaner way to do it. ☺
One other question, I got your patch to aubdump in intel-gpu-tools from
intel-gfx mailing list in addition to the mesa patches, and ran intel_aubdump
-c '/path/to/aubinator --gen=hsw' glxgears. I was able to see the glxgears run
but I was also expecting the output from aubinator on my terminal. Was that not
the intended usecase for this? Or am I expecting the wrong thing from this
feature?
Thanks
Sirisha
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
