Series looks fine to me. Some minor nit below. Reviewed-by: Charmaine Lee <charmai...@vmware.com>
>From: Brian Paul <bri...@vmware.com> >Sent: Wednesday, October 19, 2016 3:07 PM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee >Subject: [PATCH 6/6] vbo: clean up with 'indent', whitespace fixes, etc in >vbo_exec_array.c >--- > src/mesa/vbo/vbo_exec_array.c | 537 ++++++++++++++++++++++-------------------- > 1 file changed, 281 insertions(+), 256 deletions(-) >diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c >@@ -687,12 +688,13 @@ vbo_exec_DrawArraysInstancedBaseInstance(GLenum mode, >GLint first, GLsizei count > static void > dump_element_buffer(struct gl_context *ctx, GLenum type) > { >- const GLvoid *map = >- ctx->Driver.MapBufferRange(ctx, 0, >- ctx->Array.VAO->IndexBufferObj->Size, >- GL_MAP_READ_BIT, >- ctx->Array.VAO->IndexBufferObj, >- MAP_INTERNAL); >+ const GLvoid *map = ctx->Driver.MapBufferRange(ctx, 0, >+ ctx->Array.VAO-> >+ IndexBufferObj->Size, I prefer not to break up this line. It makes it less readable. >+ GL_MAP_READ_BIT, >+ ctx->Array.VAO-> >+ IndexBufferObj, Same here. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev