Ilia Mirkin <imir...@alum.mit.edu> writes: > On Mon, Nov 14, 2016 at 6:55 AM, Lionel Landwerlin > <lionel.g.landwer...@intel.com> wrote: >> On 11/11/16 18:39, Ilia Mirkin wrote: >>> On Fri, Nov 11, 2016 at 10:40 AM, Lionel Landwerlin <llandwer...@gmail.com> >>> wrote: >>>> diff --git a/src/mesa/main/extensions_table.h >>>> b/src/mesa/main/extensions_table.h >>>> index 2dbd7da..f58f2ad 100644 >>>> --- a/src/mesa/main/extensions_table.h >>>> +++ b/src/mesa/main/extensions_table.h >>>> @@ -315,6 +315,7 @@ EXT(NV_depth_clamp , >>>> ARB_depth_clamp >>>> EXT(NV_draw_buffers , dummy_true >>>> , x , x , x , ES2, 2011) >>>> EXT(NV_fbo_color_attachments , dummy_true >>>> , x , x , x , ES2, 2010) >>>> EXT(NV_fog_distance , NV_fog_distance >>>> , GLL, x , x , x , 2001) >>>> +EXT(NV_image_formats , NV_image_formats >>>> , GLL, GLC, x , 31, 2014) >>> >>> This is a GLES-only ext. You want "x" in the GLL and GLC spots. >>> >>> Also, is this strictly necessary? I'd recommend dropping the new >>> boolean and just using ARB_shader_image_load_store here. That would >>> mean this gets auto-enabled for all ES 3.1-supporting drivers. (Since >>> there's no new functionality on top of what >>> ARB_shader_image_load_store requires.) >> >> >> Thanks. >> >> Though I'm a bit perplex with what you're proposing. >> ARB_shader_image_load_store is an OpenGL 3.2 extension, how's that supposed >> to work with applications using GLES? > > It's just a bit in gl_extensions. One that indicates support for the > features required by that extension. NV_image_formats is a subset of > ARB_shader_image_load_store functionality, so if a backend supports > the latter, it'll also support the former. [As an aside, I believe we > only enable ES 3.1 if gl_extensions.ARB_shader_image_load_store is > set, so you could ultimately make this into dummy_true - either way's > good with me.] >
Agreed, the NV_image_formats bit seems redundant at this point because ARB_shader_image_load_store provides roughly the same functionality. > Cheers, > > -ilia > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev