> >>> if (dri2_surf->dri_image_front) {
> >>> - _eglLog(_EGL_DEBUG, "%s : %d : destroy dri_image_front", __func__,
> __LINE__);
> >>> + _eglLog(_EGL_DEBUG, "destroy dri_image_front");
> >>> dri2_dpy->image->destroyImage(dri2_surf->dri_image_front);
> >>> dri2_surf->dri_image_front = NULL;
> >>> }
> >> Unrelated changes ?
Refer to mesa code, uniform coding(log) style.
These logs were added in pbuffer implementation patch, so I changed them in
this enhance patch.
> >> This way things would be reasonably simple and reusable.
> >> Hit I'm thinking that we want to unify much/most of the
> >> platform_foo.c code... one of these days.
> >
> > Hmm, pbuffer handling should be mostly the same for all (I'm
> > guessing that X11 might be doing some funky stuff, though...). I was
> > wondering why we even need to have any pbuffer code in platform backends.
> > (Pixmaps and windows are a different, completely platform-specific
> > thing, though...)
> >
> Roughly what I'm wondering as well ;-)
This patch mainly resolve multiple bits requirement of pbuffer implemental.
If it's correct, could you merge it ?
Best Regards,
Zhiquan
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
