Interesting. My testing was done using piglit on an avx512 capable processor, where I didn’t see any regressions.
llvmpipe’s “make check” also passes for me with this change on avx2 and avx512 machines. Was this the only regression you saw? -Tim > On Dec 6, 2016, at 12:27 AM, Michel Dänzer <mic...@daenzer.net> wrote: > > On 06/12/16 02:39 AM, Tim Rowley wrote: >> Use llvm provided API based on cpuid rather than our own >> manually mantained list of mattr enabling/disabling. > > This change broke the llvmpipe unit test lp_test_format for me: > > Testing PIPE_FORMAT_R32_FLOAT (float) ... > FAILED > Packed: 00 00 00 00 > Unpacked (0,0): 1 0 0 1 obtained > 0 0 0 1 expected > FAILED > Packed: 00 00 80 bf > Unpacked (0,0): 1 0 0 1 obtained > -1 0 0 1 expected > > > This is on: > > processor : 0 > vendor_id : AuthenticAMD > cpu family : 21 > model : 48 > model name : AMD A10-7850K Radeon R7, 12 Compute Cores 4C+8G > stepping : 1 > microcode : 0x6003106 > cpu MHz : 4100.000 > cache size : 2048 KB > physical id : 0 > siblings : 4 > core id : 0 > cpu cores : 2 > apicid : 16 > initial apicid : 0 > fpu : yes > fpu_exception : yes > cpuid level : 13 > wp : yes > flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov > pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb > rdtscp lm constant_tsc rep_good nopl nonstop_tsc extd_apicid aperfmperf > eagerfpu pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 popcnt aes xsave > avx f16c lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse > 3dnowprefetch osvw ibs xop skinit wdt lwp fma4 tce nodeid_msr tbm topoext > perfctr_core perfctr_nb bpext ptsc cpb hw_pstate vmmcall fsgsbase bmi1 > xsaveopt arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid > decodeassists pausefilter pfthreshold overflow_recov > bugs : fxsave_leak sysret_ss_attrs null_seg > bogomips : 8200.42 > TLB size : 1536 4K pages > clflush size : 64 > cache_alignment : 64 > address sizes : 48 bits physical, 48 bits virtual > power management: ts ttp tm 100mhzsteps hwpstate cpb eff_freq_ro [13] > > > > -- > Earthling Michel Dänzer | http://www.amd.com > Libre software enthusiast | Mesa and X developer _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
