On Wed, 2017-01-04 at 15:34 -0800, Kenneth Graunke wrote:
> On Wednesday, January 4, 2017 1:26:20 PM PST Iago Toral Quiroga
> wrote:
> >
> > From: Chris Wilson <ch...@chris-wilson.co.uk>
> [snip]
> >
> > + /* And afterwards clear the register */
> > + if (reset) {
> > + *batch++ = MI_LOAD_REGISTER_IMM | (3 - 2);
> > + *batch++ = reg;
> > + *batch++ = 0;
> > + }
> Just noticed this bonus change. We didn't do this before. Normally
> it
> shouldn't sneak in on a commit that moves when we do things. But it
> seems reasonable, and I don't really care that much. So don't worry
> about it.
Right, I did not notice this. The original code said we were already
resetting this register before using it (I did not check if that is
really true), in which case this should not be necessary. In any case I
agree this might be a reasonable thing to do here.
Iago
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
