Am 19.01.2017 um 07:45 schrieb Michel Dänzer:
On 19/01/17 02:10 PM, Nayan Deshmukh wrote:
PresentPixmap only works if the pixmap depth and format matches
with the window, otherwise it returns a BadMatch protocol error.
Nitpick: PresentPixmap only returns BadMatch if the depths don't match.
It doesn't know anything about formats, so if the VDPAU format doesn't
match the window visual, PresentPixmap will "work" but the result will
have incorrect colours.
Other than that, looks good to me.
Additional to what Michel wrote, please add this comment to the code and
not only the commit message.
Apart from that it looks good to me as well.
Regards,
Christian.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
