On Thursday, 2017-02-02 16:59:24 +0100, Nicolai Hähnle wrote: > Ping after a week - does anybody still want to take a look at this?
I don't know enough to review the spec and decide whether this is the right thing to do (although it looks reasonable), but the implementation matches what the spec says, the code looks good and the enum are in Mesa's private range, so patches #2 & #3 are: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > > On 26.01.2017 12:50, Nicolai Hähnle wrote: > > Hi all, > > > > this is mostly motivated by the need to support more screen depths than > > just 24/32-bit RGB in Glamor. The extension is simple enough, just adding > > three more enums that are accepted. > > > > I _think_ every DRI driver that exposes EGL_MESA_drm_image should be able > > to support this new extension as well, since EGL_MESA_drm_image requires > > DRI image version 10 to be enabled, and the corresponding > > __DRI_IMAGE_FORMAT_* values have been there since DRI image version 5, but > > do let me know if that thinking is wrong. > > > > I'd like to land at least the first patch relatively quickly, to avoid > > future > > enum clashes. Internally, we had already accidentally used an enum that is > > used by one of the WL extensions, since those are not in the EGL registry... > > > > Please review / provide feedback! > > > > Thanks, > > Nicolai > > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
