I think the comment affects the hunk after these checks, so maybe removing the checks after the comment makes more sense?
Either way: Reviewed-by: Iago Toral Quiroga <ito...@igalia.com> On Fri, 2017-02-24 at 15:10 +0200, Juha-Pekka Heikkila wrote: > On both sides of the comment on what's being checked are exactly > same checks in different order. I took out ones before the comment > so comment can stay in place. > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikk...@gmail.com> > --- > src/mesa/drivers/dri/i965/brw_eu_validate.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_validate.c > b/src/mesa/drivers/dri/i965/brw_eu_validate.c > index 64615af..3655dde 100644 > --- a/src/mesa/drivers/dri/i965/brw_eu_validate.c > +++ b/src/mesa/drivers/dri/i965/brw_eu_validate.c > @@ -407,18 +407,6 @@ > general_restrictions_based_on_operand_types(const struct > gen_device_info *devinf > unsigned exec_size = 1 << brw_inst_exec_size(devinfo, inst); > struct string error_msg = { .str = NULL, .len = 0 }; > > - if (num_sources == 3) > - return (struct string){}; > - > - if (inst_is_send(devinfo, inst)) > - return (struct string){}; > - > - if (exec_size == 1) > - return (struct string){}; > - > - if (desc->ndst == 0) > - return (struct string){}; > - > /* The PRMs say: > * > * Where n is the largest element size in bytes for any source > or _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev