On 24 March 2017 at 18:02, Chad Versace <chadvers...@chromium.org> wrote: > On Fri 24 Mar 2017, Emil Velikov wrote: >> Hi Chad, >> >> On 23 March 2017 at 01:04, Chad Versace <chadvers...@chromium.org> wrote: >> > Validate that isl_surf::row_pitch fits in the below bitfields, >> > if applicable based on isl_surf::usage. >> > >> > RENDER_SURFACE_STATE::SurfacePitch >> > RENDER_SURFACE_STATE::AuxiliarySurfacePitch >> > 3DSTATE_DEPTH_BUFFER::SurfacePitch >> > 3DSTATE_HIER_DEPTH_BUFFER::SurfacePitch >> > >> > v2: Add a Makefile dependency on generated header genX_bits.h. >> > --- >> > src/intel/Makefile.isl.am | 3 ++ >> > src/intel/isl/isl.c | 72 >> > +++++++++++++++++++++++++++++++++++++++++++---- >> > 2 files changed, 69 insertions(+), 6 deletions(-) >> > >> > diff --git a/src/intel/Makefile.isl.am b/src/intel/Makefile.isl.am >> > index ee2215df1d1..09a10281b45 100644 >> > --- a/src/intel/Makefile.isl.am >> > +++ b/src/intel/Makefile.isl.am >> > @@ -63,6 +63,9 @@ isl/isl_format_layout.c: isl/gen_format_layout.py \ >> > $(PYTHON_GEN) $(srcdir)/isl/gen_format_layout.py \ >> > --csv $(srcdir)/isl/isl_format_layout.csv --out $@ >> > >> > +# Dependencies on generated files >> > +$(builddir)/isl/isl.o: $(srcdir)/genxml/genX_bits.h >> > + >> Can we have this as below. We could also squash it with 3/9. >> >> BUILT_SOURCES += genxml/genX_bits.h >> EXTRA_DIST += genxml/genX_bits.h > > Patch 3/9, in Makefile.gexml.am, does > GENXML_GENERATED_FILES += genxml/genX_bits.h > which indirectly accomplishes > BUILT_SOURCES += genxml/genX_bits.h > EXTRA_DIST += genxml/genX_bits.h > Right i got confused by the simultaneous rename + adding the new file.
> Do you me want to drop this? > $(builddir)/isl/isl.o: $(srcdir)/genxml/genX_bits.h > I'll drop it if you want. > That'll be great, thank you. > I don't understand autoconf... I added the dependency because I was > unsure how BUILT_SOURCES worked. All the files listed in BUILT_SOURCES, through the whole tree, are generated before any compilation has started. -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev