Hi, On Sunday, November 27, 2011 22:52:29 Eric Anholt wrote: > Not an issue for this patch, but I noticed that there's this > _mesa_update_array_object_max_element that does something similar, but > doesn't follow this rule and would trash the _MaxElement value. Some > day, the body of this function should probably be moved to that one, and > state.c should call it. > > It's also a bit disturbing that the code for which array to look at > based on program state is duplicated between vbo and here. Thanks, agreed.
There is really a huge pile of cleanup possible in this area. I had included some of the 'easy cleanups' in the v1 series but it turned out that there is some surprising clause in one of the extension specs that I just missed. So for now I resorted to the bare minimum to get the array change in. Then start thinking about cleanups enabled with this change. > Other than the one patch with comments, the series overall looks like a > great clenaup and is: > > Reviewed-by: Eric Anholt <e...@anholt.net> Thanks for looking into this! Mathias _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev