On Tue, Apr 11, 2017 at 09:02:51AM -0700, Kenneth Graunke wrote: > If we have buffers larger than 4GB, then target_offset will need to > become a 64-bit value. Delta is only a __u32 though, so we downcast. > > Suggested by Chris Wilson.
I retract that suggestion. There's no value in going above and beyond the current kernel limitations (how do we test?) and only makes things a little more complicated wrt to type handling (since reloc->delta is actually a sint32_t and not a uint32_t). Hmm, it does have some value in catching overflows, maybe? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
